Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted table font size to rem #2401

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Converted table font size to rem #2401

merged 1 commit into from
Dec 10, 2024

Conversation

thomas-mathai
Copy link
Contributor

@thomas-mathai thomas-mathai commented Dec 10, 2024 •
edited
Loading

Description

  • Changed: Table font size unit from px to rem.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

@thomas-mathai thomas-mathai added the patch Releases small requests or bug fixes. label Dec 10, 2024
@thomas-mathai thomas-mathai marked this pull request as ready for review December 10, 2024 13:47
@thomas-mathai
Copy link
Contributor Author

@praveen-murali-ind _a Can you please check?

praveen-murali-ind
praveen-murali-ind approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@praveen-murali-ind praveen-murali-ind merged commit b3a224b into main Dec 10, 2024
1 check passed
@praveen-murali-ind praveen-murali-ind deleted the 2399-convert-table-font-size-from-px-to-rem branch December 10, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen-murali-ind praveen-murali-ind praveen-murali-ind approved these changes

Assignees

@praveen-murali-ind praveen-murali-ind

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Table font size style to use rem instead of px
2 participants
@thomas-mathai @praveen-murali-ind