Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed height computation issue in Pane component #2407

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fixed height computation issue in Pane component #2407

merged 2 commits into from
Jan 21, 2025

Conversation

josephmathew900
Copy link
Contributor

Description

  • Fixed height computation issue in Pane component.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2407 January 20, 2025 13:22 Inactive
@josephmathew900 josephmathew900 force-pushed the 2406-fix-height-computation-issue-in-pane branch from 08098b9 to 2fa6009 Compare January 20, 2025 14:06
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2407 January 20, 2025 14:06 Inactive
@josephmathew900 josephmathew900 force-pushed the 2406-fix-height-computation-issue-in-pane branch from 2fa6009 to f7cd497 Compare January 20, 2025 14:33
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2407 January 20, 2025 14:33 Inactive
@josephmathew900 josephmathew900 force-pushed the 2406-fix-height-computation-issue-in-pane branch from f7cd497 to 17c5017 Compare January 20, 2025 14:49
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2407 January 20, 2025 14:49 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2407 January 20, 2025 14:50 Inactive
@josephmathew900 josephmathew900 force-pushed the 2406-fix-height-computation-issue-in-pane branch from 25c99ce to 5780c68 Compare January 20, 2025 15:10
@neetodeploy neetodeploy bot requested a deployment to neeto-ui-1f4k-pr-2407 January 20, 2025 15:10 In progress
@josephmathew900 josephmathew900 force-pushed the 2406-fix-height-computation-issue-in-pane branch from 5780c68 to e90431d Compare January 20, 2025 16:24
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2407 January 20, 2025 16:24 Inactive
@josephmathew900 josephmathew900 force-pushed the 2406-fix-height-computation-issue-in-pane branch from e90431d to 051408c Compare January 20, 2025 16:44
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2407 January 20, 2025 16:44 Inactive
@josephmathew900 josephmathew900 force-pushed the 2406-fix-height-computation-issue-in-pane branch from 051408c to 9df43dc Compare January 20, 2025 16:58
@josephmathew900 josephmathew900 added the patch Releases small requests or bug fixes. label Jan 21, 2025
@josephmathew900
Copy link
Contributor Author

@praveen-murali-ind _a Please review.

praveen-murali-ind
praveen-murali-ind approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephmathew900 _A LGTM. I have verified the changes in NeetoCal.

spinkart lvh me_9026_admin_bookings_jzrxyec_view=all

@praveen-murali-ind praveen-murali-ind merged commit b7c03e2 into main Jan 21, 2025
1 check passed
@praveen-murali-ind praveen-murali-ind deleted the 2406-fix-height-computation-issue-in-pane branch January 21, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen-murali-ind praveen-murali-ind praveen-murali-ind approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix height computation issue in Pane component
2 participants
@josephmathew900 @praveen-murali-ind