Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber multi-wp installs #101

Open
wants to merge 2 commits into
base: release/1.0.0
Choose a base branch
from

Conversation

ampersarnie
Copy link
Member

Description

There have been difficulties getting Cucumber and .feature files running on multi-wp testing setups. This seems to be happening because during the copy and parse of the test files, WP-Cypress is attempting to parse .feature files as though they are .js files. This parsing is not required for these files, so they can and should be skipped.

Change Log

  • Adds file check to parse script.

Screenshots/Videos

If PR includes visual changes, please include a screenshot (or short video if applicable).
Screenshot 2022-07-17 at 23 14 09

Types of changes (if applicable):

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist (if applicable):

  • Meets provided linting standards.

@ampersarnie ampersarnie marked this pull request as ready for review July 18, 2022 08:39
@PaulREnglish
Copy link
Contributor

PaulREnglish commented Aug 2, 2022

@ampersarnie I'm having trouble reproducing the problem you described. Does this problem only occur if your different sites have different versions of WordPress installed?

@ampersarnie
Copy link
Member Author

@PaulREnglish I'll put together an example repo for you so you can test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants