-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce document classes #245
Open
DigitalTimK
wants to merge
8
commits into
bigbluebutton:develop
Choose a base branch
from
DigitalTimK:feature/DocumentClass
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Introduce document classes #245
DigitalTimK
wants to merge
8
commits into
bigbluebutton:develop
from
DigitalTimK:feature/DocumentClass
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The current way to manage documents is very inconsistent (following the same inconsistent way as on the BBB-Server API side). Sometimes they are called documents and sometimes presentations. For example there is currently a class called "SomeThingDocument" but has a
addPresentation
-function.In addition the
addPresentation
-function is unclear regarding their parameter and how they will support the required result. Either by URL or by embedded data stream. So a separation into two cases (=classes) makes senses.On top the
addPresentation
-function required the user to pass the data-stream directly.This PR will
DocumentUrl
-class andDocumentFile
-class (including their related abstract class and interface class)presentation
-related function and classesThis PR will close #244