Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix balance calculation #784

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kochie
Copy link
Contributor

@kochie kochie commented Jan 28, 2025

This PR fixes an issue I had where editing an invoice for a service that uses rate and quantity will fail because there is no total value. This will result in a NaN being used to update the db causing a 500 failure on the server.

I'm not sure if this is happening to anyone else. But the reproduction steps for me.

  1. Create an invoice for a service with a product with a rate.
  2. Try to edit the invoice in any way.
  3. Save the invoice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant