fix(cli): CLI freezes before continuing (#1480)

bigcommerce · Oct 18, 2024 · eb1707b · eb1707b
1 parent 0686074
commit eb1707b
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 42 deletions.
diff --git a/.changeset/dirty-starfishes-guess.md b/.changeset/dirty-starfishes-guess.md
@@ -0,0 +1,5 @@
+---
+"@bigcommerce/create-catalyst": patch
+---
+
+Fix the CLI from hanging while waiting for segment.
diff --git a/packages/create-catalyst/src/utils/telemetry/telemetry.ts b/packages/create-catalyst/src/utils/telemetry/telemetry.ts
@@ -46,54 +46,44 @@ export class Telemetry {
   }
 
   async track(eventName: string, payload: Record<string, unknown>) {
-    await new Promise((resolve) => {
-      if (!this.isEnabled()) {
-        resolve(undefined);
-      }
-
-      this.analytics.track(
-        {
-          event: eventName,
-          anonymousId: this.getAnonymousId(),
-          properties: {
-            ...payload,
-            sessionId: this.sessionId,
-          },
-          context: {
-            app: {
-              name: this.projectName,
-              version: this.projectVersion,
-            },
-          },
+    if (!this.isEnabled()) {
+      return Promise.resolve(undefined);
+    }
+
+    this.analytics.track({
+      event: eventName,
+      anonymousId: this.getAnonymousId(),
+      properties: {
+        ...payload,
+        sessionId: this.sessionId,
+      },
+      context: {
+        app: {
+          name: this.projectName,
+          version: this.projectVersion,
         },
-        resolve,
-      );
+      },
     });
   }
 
   async identify(storeHash?: string) {
-    await new Promise((resolve) => {
-      if (!this.isEnabled()) {
-        resolve(undefined);
-      }
-
-      if (!storeHash) {
-        resolve(undefined);
-      }
-
-      this.analytics.identify(
-        {
-          userId: storeHash,
-          anonymousId: this.getAnonymousId(),
-          context: {
-            app: {
-              name: this.projectName,
-              version: this.projectVersion,
-            },
-          },
+    if (!this.isEnabled()) {
+      return Promise.resolve(undefined);
+    }
+
+    if (!storeHash) {
+      return Promise.resolve(undefined);
+    }
+
+    this.analytics.identify({
+      userId: storeHash,
+      anonymousId: this.getAnonymousId(),
+      context: {
+        app: {
+          name: this.projectName,
+          version: this.projectVersion,
         },
-        resolve,
-      );
+      },
     });
   }