feat(core): add localized data-fetching #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5caf1e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bookernath
approved these changes
Dec 3, 2024
jorgemoya
approved these changes
Dec 4, 2024
becomevocal
reviewed
Dec 4, 2024
chanceaclark
force-pushed
the
feat/shopper-locale
branch
from
f44bd3f to
0c3e75f
Compare
chanceaclark
force-pushed
the
feat/shopper-locale
branch
from
0c3e75f to
5caf1e1
Compare
deini
approved these changes
Dec 4, 2024
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-j8ybtdeee-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Passes the shopper locale into the client request which responds back with localized catalog data. It should also return other localized data, which is done by passing the
Accept-Languageheader in the client request.Testing
EN
https://catalyst-latest-git-feat-shopper-locale-bigcommerce-platform.vercel.app/smith-journal-13/
ES
https://catalyst-latest-git-feat-shopper-locale-bigcommerce-platform.vercel.app/es/smith-journal-13/