Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't rewrite Next.js server actions' requests #1706

Closed

Conversation

agurtovoy
Copy link
Contributor

What/Why?

Behind the scenes, Next.js server actions are translated into POST requests that get handled by the framework. withRoutes middleware was intercepting and rewriting these requests as page renders.

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: dcb5bc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 0:59am
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 0:59am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 5, 2024 0:59am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 0:59am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 0:59am

@agurtovoy agurtovoy force-pushed the fix/dont-rewrite-server-actions branch from 7e3c8c5 to dcb5bc1 Compare December 5, 2024 00:55
@bookernath
Copy link
Contributor

@agurtovoy nice catch. should this PR perhaps be to main? I think this is relevant to all users of Catalyst.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-d6suoc5gy-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

@agurtovoy
Copy link
Contributor Author

@bookernath Good point, closing this one in favor of #1707

@agurtovoy agurtovoy closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants