Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sticky sidebar layout overflow #1895

Conversation

apledger
Copy link
Contributor

What/Why?

When using an Image inside of a StickySidebarLayout a min width was being set preventing it from shrinking in a flex layout. This PR fixes this by setting a min width of 0 on the columns in the StickySidebarLayout component.

Testing

CleanShot 2025-01-10 at 16 33 39

@apledger apledger requested a review from migueloller January 10, 2025 21:33
@apledger apledger requested a review from a team as a code owner January 10, 2025 21:33
Copy link

linear bot commented Jan 10, 2025

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: c1ff5b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 9:33pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 9:33pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 10, 2025 9:33pm
catalyst-au ⬜️ Ignored (Inspect) Jan 10, 2025 9:33pm
catalyst-uk ⬜️ Ignored (Inspect) Jan 10, 2025 9:33pm

@andrewreifman andrewreifman added this pull request to the merge queue Jan 10, 2025
Merged via the queue into canary with commit 5da202e Jan 10, 2025
9 checks passed
@andrewreifman andrewreifman deleted the alan/eng-7323-sticky-sidebar-content-slot-is-not-behaving-responsively branch January 10, 2025 22:11
apledger added a commit that referenced this pull request Jan 10, 2025
apledger added a commit that referenced this pull request Jan 10, 2025
bookernath pushed a commit that referenced this pull request Jan 17, 2025
kathir-arizon pushed a commit to Arizon-Digital/catalyst-cuts-metal that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants