Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dividers in nav #1896

Conversation

apledger
Copy link
Contributor

What/Why?

Improved the styles of the navigation menu by removing dividers, shrinking text of group links, adding a max width, and increasing columns to 5.

Testing

CleanShot 2025-01-10 at 17 15 05

@apledger apledger requested a review from a team as a code owner January 10, 2025 22:15
Copy link

linear bot commented Jan 10, 2025

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 4a037f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 10:19pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 10:19pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 10, 2025 10:19pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 10:19pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 10:19pm

@apledger apledger force-pushed the alan/eng-7369-header-dividers-not-rendering-correctly-on-demo-site branch from e3a5cda to 4a037f5 Compare January 10, 2025 22:16
@andrewreifman andrewreifman added this pull request to the merge queue Jan 10, 2025
Merged via the queue into canary with commit 49092bf Jan 10, 2025
8 checks passed
@andrewreifman andrewreifman deleted the alan/eng-7369-header-dividers-not-rendering-correctly-on-demo-site branch January 10, 2025 22:20
apledger added a commit that referenced this pull request Jan 10, 2025
apledger added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants