Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass type into signIn, redirect to account/orders #1905

Merged

Conversation

apledger
Copy link
Contributor

What/Why?

Adds a type field to signIn and handles graphql errors.

Testing

Can't record a video because I'm getting rate limited.

@apledger apledger requested a review from a team as a code owner January 13, 2025 21:13
Copy link

linear bot commented Jan 13, 2025

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 0306ca2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:33pm
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:33pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:33pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:33pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:33pm

@apledger apledger force-pushed the alan/eng-7377-customer-account-registration-is-broken branch from 7c230c8 to 989b02c Compare January 13, 2025 21:30
Merged via the queue into canary with commit d70596e Jan 13, 2025
8 checks passed
@apledger apledger deleted the alan/eng-7377-customer-account-registration-is-broken branch January 13, 2025 21:36
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
bookernath pushed a commit that referenced this pull request Jan 17, 2025
* fix: pass type into signIn, redirect to account/orders

* fix: properly handle graphql error in registerCustomer

* chore: changeset
BC-krasnoshapka pushed a commit that referenced this pull request Jan 23, 2025
* fix: pass type into signIn, redirect to account/orders

* fix: properly handle graphql error in registerCustomer

* chore: changeset
kathir-arizon pushed a commit to Arizon-Digital/catalyst-cuts-metal that referenced this pull request Feb 4, 2025
)

* fix: pass type into signIn, redirect to account/orders

* fix: properly handle graphql error in registerCustomer

* chore: changeset
chanceaclark pushed a commit that referenced this pull request Feb 5, 2025
* fix: pass type into signIn, redirect to account/orders

* fix: properly handle graphql error in registerCustomer

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants