Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): only make links and cart count streamed in in header #1945

Open
wants to merge 34 commits into
base: canary
Choose a base branch
from

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Jan 30, 2025

What/Why?

Splits the navigation links and footer sections from the Layout request, to be able to fetch dynamically via PPR.

Kapture.2025-01-31.at.12.19.01.mp4

Testing

Shows skeletons on render, the rest of the header is a static component.

Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: a8b5025

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 6:21pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 31, 2025 6:21pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 6:21pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 6:21pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 6:21pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-ijo1e7g0j-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 88
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant