Skip to content

feat(payment): Added AppSwitch #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(payment): Added AppSwitch #2961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/paypal-commerce-integration/src/paypal-commerce-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,8 @@ export interface PayPalCommerceButtons {
render(id: string): void;
close(): void;
isEligible(): boolean;
hasReturned?(): boolean;
resume?(): void;
}

export interface PayPalCommerceButtonsOptions {
Expand Down
3 changes: 3 additions & 0 deletions ...s/paypal-commerce-integration/src/paypal-commerce/paypal-commerce-button-strategy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ describe('PayPalCommerceButtonStrategy', () => {
await strategy.initialize(initializationOptions);

expect(paypalSdk.Buttons).toHaveBeenCalledWith({
appSwitchWhenAvailable: true,
fundingSource: paypalSdk.FUNDING.PAYPAL,
style: paypalCommerceOptions.style,
createOrder: expect.any(Function),
Expand All @@ -382,6 +383,7 @@ describe('PayPalCommerceButtonStrategy', () => {
await strategy.initialize(buyNowInitializationOptions);

expect(paypalSdk.Buttons).toHaveBeenCalledWith({
appSwitchWhenAvailable: true,
fundingSource: paypalSdk.FUNDING.PAYPAL,
style: paypalCommerceOptions.style,
createOrder: expect.any(Function),
Expand All @@ -408,6 +410,7 @@ describe('PayPalCommerceButtonStrategy', () => {
await strategy.initialize(initializationOptions);

expect(paypalSdk.Buttons).toHaveBeenCalledWith({
appSwitchWhenAvailable: true,
fundingSource: paypalSdk.FUNDING.PAYPAL,
style: paypalCommerceOptions.style,
createOrder: expect.any(Function),
Expand Down
10 changes: 9 additions & 1 deletion packages/paypal-commerce-integration/src/paypal-commerce/paypal-commerce-button-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export default class PayPalCommerceButtonStrategy implements CheckoutButtonStrat
const { isHostedCheckoutEnabled } = paymentMethod.initializationData || {};

const defaultCallbacks = {
appSwitchWhenAvailable: true, // Need an indicator to trigger App Switch
createOrder: () => this.paypalCommerceIntegrationService.createOrder('paypalcommerce'),
onApprove: ({ orderID }: ApproveCallbackPayload) =>
this.paypalCommerceIntegrationService.tokenizePayment(methodId, orderID),
Expand Down Expand Up @@ -134,7 +135,14 @@ export default class PayPalCommerceButtonStrategy implements CheckoutButtonStrat
const paypalButton = paypalSdk.Buttons(buttonRenderOptions);

if (paypalButton.isEligible()) {
paypalButton.render(`#${containerId}`);
// AppSwitch Flow
if (paypalButton?.hasReturned && paypalButton.hasReturned()) {
if (paypalButton.resume) {
paypalButton?.resume();
}
} else {
paypalButton.render(`#${containerId}`);
}
} else if (onEligibilityFailure && typeof onEligibilityFailure === 'function') {
onEligibilityFailure();
} else {
Expand Down