Skip to content

feat(payment): PAYPAL-2615 moved braintree visa checkout to separate package #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

feat(payment): PAYPAL-2615 moved braintree visa checkout to separate package #3021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions ...e-integration/src/braintree-visa-checkout/braintree-visa-checkout-button-strategy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ import {
getBraintree,
getDataCollectorMock,
getDeviceDataMock,
getPaymentSuccessPayload,
getVisaCheckoutMock,
getVisaCheckoutSDKMock,
VisaCheckoutHostWindow,
VisaCheckoutPaymentSuccessPayload,
VisaCheckoutSDK,
} from '@bigcommerce/checkout-sdk/braintree-utils';
import {
Expand All @@ -39,6 +41,7 @@ describe('BraintreeVisaCheckoutButtonStrategy', () => {
let braintreeVisaCheckoutButtonElement: HTMLDivElement;
let dataCollector: BraintreeDataCollector;
let braintreeSDKVersionManager: BraintreeSDKVersionManager;
let visaPayload: VisaCheckoutPaymentSuccessPayload;

const defaultContainerId = 'braintree-visa-checkout-button-mock-id';

Expand All @@ -48,6 +51,8 @@ describe('BraintreeVisaCheckoutButtonStrategy', () => {
};

beforeEach(() => {
visaPayload = getPaymentSuccessPayload();

mockWindow = {} as VisaCheckoutHostWindow & BraintreeHostWindow;

dataCollector = getDataCollectorMock();
Expand Down Expand Up @@ -180,13 +185,8 @@ describe('BraintreeVisaCheckoutButtonStrategy', () => {
});

it('visa Checkout tokenization', async () => {
// TODO: remove rule and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/no-misused-promises
visaCheckoutSDKMock.on = jest.fn((type, callback) => {
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
return type === 'payment.success' ? callback('data') : undefined;
jest.spyOn(visaCheckoutSDKMock, 'on').mockImplementation((_, callback) => {
callback(visaPayload, new Error());
});

await strategy.initialize(initializationOptions);
Expand All @@ -209,13 +209,8 @@ describe('BraintreeVisaCheckoutButtonStrategy', () => {
postal_code: '2008',
});

// TODO: remove rule and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/no-misused-promises
visaCheckoutSDKMock.on = jest.fn((type, callback) => {
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
return type === 'payment.success' ? callback('data') : undefined;
jest.spyOn(visaCheckoutSDKMock, 'on').mockImplementation((_, callback) => {
callback(visaPayload, new Error());
});

await strategy.initialize(initializationOptions);
Expand Down
77 changes: 22 additions & 55 deletions ...integration/src/braintree-visa-checkout/braintree-visa-checkout-customer-strategy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ import {
getBraintree,
getDataCollectorMock,
getDeviceDataMock,
getPaymentSuccessPayload,
getVisaCheckoutMock,
getVisaCheckoutSDKMock,
VisaCheckoutHostWindow,
VisaCheckoutPaymentSuccessPayload,
VisaCheckoutSDK,
} from '@bigcommerce/checkout-sdk/braintree-utils';
import {
Expand Down Expand Up @@ -41,6 +43,7 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {
let braintreeVisaCheckoutButtonElement: HTMLDivElement;
let dataCollector: BraintreeDataCollector;
let braintreeSDKVersionManager: BraintreeSDKVersionManager;
let visaPayload: VisaCheckoutPaymentSuccessPayload;

const defaultContainerId = 'braintree-visa-checkout-button-mock-id';

Expand All @@ -54,6 +57,8 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {
};

beforeEach(() => {
visaPayload = getPaymentSuccessPayload();

mockWindow = {} as VisaCheckoutHostWindow & BraintreeHostWindow;

dataCollector = getDataCollectorMock();
Expand Down Expand Up @@ -91,29 +96,19 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {
jest.spyOn(paymentIntegrationService.getState(), 'getPaymentMethodOrThrow').mockReturnValue(
paymentMethodMock,
);
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
jest.spyOn(paymentIntegrationService, 'loadCheckout').mockReturnValue(true);
jest.spyOn(paymentIntegrationService, 'loadCheckout');

jest.spyOn(braintreeSdk, 'initialize');
jest.spyOn(braintreeSdk, 'deinitialize');
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
jest.spyOn(braintreeSdk, 'getBraintreeVisaCheckout').mockReturnValue(braintreeVisaCheckout);
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
jest.spyOn(braintreeSdk, 'getDataCollectorOrThrow').mockReturnValue(dataCollector);

// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
jest.spyOn(braintreeSdk, 'getBraintreeVisaCheckout').mockResolvedValue(
braintreeVisaCheckout,
);
jest.spyOn(braintreeSdk, 'getDataCollectorOrThrow').mockResolvedValue(dataCollector);

jest.spyOn(braintreeSdk, 'getVisaCheckoutSdk').mockImplementation(() => {
mockWindow.V = visaCheckoutSDKMock;

return mockWindow.V;
return Promise.resolve(mockWindow.V);
});

jest.spyOn(formPoster, 'postForm').mockImplementation(() => {});
Expand All @@ -135,7 +130,6 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {
try {
await strategy.initialize({
...initializationOptions,
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
braintreevisacheckout: {},
Expand Down Expand Up @@ -163,14 +157,7 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {

it('throws error if methodId is missing', async () => {
try {
await strategy.initialize({
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
braintreevisacheckout: {
...initializationOptions.braintreevisacheckout,
},
});
await strategy.initialize({});
} catch (error) {
expect(error).toBeInstanceOf(InvalidArgumentError);
}
Expand Down Expand Up @@ -209,13 +196,8 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {
});

it('visa Checkout tokenization', async () => {
// TODO: remove rule and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/no-misused-promises
visaCheckoutSDKMock.on = jest.fn((type, callback) => {
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
return type === 'payment.success' ? callback('data') : undefined;
jest.spyOn(visaCheckoutSDKMock, 'on').mockImplementation((_, callback) => {
callback(visaPayload, new Error());
});

await strategy.initialize(initializationOptions);
Expand All @@ -225,13 +207,8 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {
});

it('registers the error and success callbacks', async () => {
// TODO: remove rule and update test with related type (PAYPAL-4383)

visaCheckoutSDKMock.on = jest.fn((_, callback) => {
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
callback();
jest.spyOn(visaCheckoutSDKMock, 'on').mockImplementation((_, callback) => {
callback(visaPayload, new Error());
});
await strategy.initialize(initializationOptions);

Expand All @@ -247,13 +224,8 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {

describe('when payment.success', () => {
beforeEach(() => {
// TODO: remove rule and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/no-misused-promises
visaCheckoutSDKMock.on = jest.fn((type, callback) => {
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
return type === 'payment.success' ? callback('data') : undefined;
jest.spyOn(visaCheckoutSDKMock, 'on').mockImplementation((_, callback) => {
callback(visaPayload, new Error());
});
});

Expand Down Expand Up @@ -301,14 +273,9 @@ describe('BraintreeVisaCheckoutCustomerStrategy', () => {
it('payment error triggers onError from the options', async () => {
const errorMock = new Error();

// TODO: remove rule and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/no-misused-promises
visaCheckoutSDKMock.on = jest.fn((type, callback) =>
// TODO: remove ts-ignore and update test with related type (PAYPAL-4383)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
type === 'payment.error' ? callback('data', errorMock) : undefined,
);
jest.spyOn(visaCheckoutSDKMock, 'on').mockImplementation((_, callback) => {
callback(visaPayload, errorMock);
});

await strategy.initialize(initializationOptions);

Expand Down
18 changes: 18 additions & 0 deletions ...intree-integration/src/braintree-visa-checkout/braintree-visa-checkout-payment-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
export default interface BraintreeVisaCheckoutPaymentInitializeOptions {
/**
* A callback that gets called when Visa Checkout fails to initialize or
* selects a payment option.
*
* @param error - The error object describing the failure.
*/
onError?(error: Error): void;

/**
* A callback that gets called when the customer selects a payment option.
*/
onPaymentSelect?(): void;
}

export interface WithBraintreeVisaCheckoutPaymentInitializeOptions {
braintreevisacheckout?: BraintreeVisaCheckoutPaymentInitializeOptions;
}
Loading