Skip to content

Commit

Permalink
Use distinct names for artifacts
Browse files Browse the repository at this point in the history
  • Loading branch information
bookernath committed Oct 19, 2024
1 parent 2698035 commit 125e1ed
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/pull_request_review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,13 @@ on:
jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node: [18.x, 20.x]

runs-on: ${{ matrix.os }}

steps:
- name: Checkout code
uses: actions/checkout@v2
Expand All @@ -32,9 +33,9 @@ jobs:
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
key: ${{ matrix.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
${{ matrix.os }}-node-${{ matrix.node }}
- name: Install Stencil CLI Dependency
run: npm install -g @bigcommerce/stencil-cli
Expand All @@ -46,13 +47,13 @@ jobs:
run: npx grunt check

- name: Validate theme successfully bundles
run: npx stencil bundle --name bundle
run: npx stencil bundle --name ${{ matrix.os }}-node-${{ matrix.node }}-bundle

- name: Upload bundled theme
uses: actions/upload-artifact@v4
with:
name: Bundled Theme
path: bundle.zip
path: ${{ matrix.os }}-node-${{ matrix.node }}-bundle.zip

- name: Upload bundle analysis
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit 125e1ed

Please sign in to comment.