fix(storefront): SD-10928 Cornerstone update to support multiple date fields and remove blank space #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, good job! Just don't forget squash your commits into one. |
…rt multiple date fields fix(storefront): SD-10928 remove space at top of date field and support multiple date fields
bc-yevhenii-buliuk
approved these changes
Jan 20, 2025
bc-alexsaiannyi
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update
date.htmlandproduct_details.jsto remove the space at the stop of date fields and to support multiple date fields per page.The ID attributes for date fields cause invalid html when there are multiple date fields on a page due to duplicate IDs.
OPTGROUP under the Day select box causes extra space in Day dropdown.
ready() call is not necessary, there already is a $scope class member which references a containing element.
Requirements
Tickets / Documentation
Screenshots
Before:
before.mov
After:
after.mov