-
Notifications
You must be signed in to change notification settings - Fork 41
DEVDOCS-6035: [update] geography nodes #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@kskomro can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- docs/storefront/graphql/examples/index.mdx: Language not supported
} | ||
} | ||
} | ||
geography { # geography node is available at the top level still for unfiltered use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
geography { # geography node is available at the top level still for unfiltered use | |
geography { |
I doubt this comment should be in the official docs, the same as above one - they were more addressed to person taking the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this query should be split in two queries -site.settings.shipping.supportedShippingDestinations and geography - and also then returned results by each can be described separately. Furthermore geography node has filers which should be explained.
DEVDOCS-6035
What changed?
Added an example for the geography node
Release notes draft
Anything else?
ping {names}