chore: CATALOG-11541 Use catalog changes in fork repo #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BC-RSikora
force-pushed
the
CATALOG-11541
branch
3 times, most recently
from
aaeb848 to
290b04e
Compare
Comment on lines
104
to
116
| protected static function getReadWriteTimeoutFromConfig(AMQPConnectionConfig $connectionConfig, array $config): void | ||
| { | ||
| $readTimeout = Arr::get($config, self::CONFIG_OPTIONS.'.read_timeout'); | ||
| $writeTimeout = Arr::get($config, self::CONFIG_OPTIONS.'.write_timeout'); | ||
|
|
||
| if (is_numeric($readTimeout) && intval($readTimeout) > 0) { | ||
| $connectionConfig->setReadTimeout((int) $readTimeout); | ||
| } | ||
|
|
||
| if (is_numeric($writeTimeout) && intval($writeTimeout) > 0) { | ||
| $connectionConfig->setWriteTimeout((int) $readTimeout); | ||
| } | ||
| } |
There was a problem hiding this comment.
If I get right, this config is the only reason of switching to fork. Isn't it?
Is it possible to use custom connection class in sake of using original vendor?
There was a problem hiding this comment.
I tried do that in previous ticket but unsuccessful because of changing Connection config class instead of Connection class. And we decided to use fork for that.
funivan
reviewed
May 28, 2025
| $readTimeout = Arr::get($config, self::CONFIG_OPTIONS.'.read_timeout'); | ||
| $writeTimeout = Arr::get($config, self::CONFIG_OPTIONS.'.write_timeout'); | ||
|
|
||
| if (is_numeric($readTimeout) && intval($readTimeout) > 0) { |
There was a problem hiding this comment.
Suggested change
| if (is_numeric($readTimeout) && intval($readTimeout) > 0) { | |
| $readTtl = is_numeric($readTimeout) ? (int)readTimeout : 0; | |
| if ($readTtl > 0) { |
🍹 cast only once.
funivan
reviewed
May 28, 2025
| @@ -99,4 +100,18 @@ protected static function getNetworkProtocolFromConfig(AMQPConnectionConfig $con | |||
| $connectionConfig->setNetworkProtocol($networkProtocol); | |||
| } | |||
| } | |||
|
|
|||
| protected static function getReadWriteTimeoutFromConfig(AMQPConnectionConfig $connectionConfig, array $config): void | |||
funivan
approved these changes
May 29, 2025
BC-YIvashchenko
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: CATALOG-11541
What/Why?
Use catalog changes in fork repo.
Cherry-picked all commits from previous repo: https://github.com/bc-ochkovskyi/laravel-queue-rabbitmq
Rollout/Rollback
Revert PR.
Testing
By unit tests:
In cat-imex service: https://github.com/bigcommerce/catalog-import-export/pull/568
In orchestrator-imex service: https://github.com/bigcommerce/import-export-service/pull/173