Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: semantic release deploy to npm #1233

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: semantic release deploy to npm #1233

merged 1 commit into from
Sep 26, 2024

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Sep 25, 2024 •
edited
Loading

What?

Semantic release wasn't updated to support ESM

Tickets / Documentation

Testing

Before:
Screenshot 2024-09-25 at 16 39 03
After:
Screenshot 2024-09-25 at 16 39 32

QA

run npm run release locally -> no ESM errors

cc @bigcommerce/storefront-team

@jairo-bc jairo-bc requested a review from a team September 25, 2024 14:39
bc-max
bc-max reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@bc-max bc-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jordanarldt
jordanarldt approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jordanarldt jordanarldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and npm run release works as expected 💚

image

@jairo-bc jairo-bc merged commit 5ed0cf3 into master Sep 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bc-max bc-max bc-max left review comments

@jordanarldt jordanarldt jordanarldt approved these changes

Assignees

@ngaar ngaar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jairo-bc @jordanarldt @bc-max @ngaar