Skip to content

Commit

Permalink
Allow coil speed == 0.
Browse files Browse the repository at this point in the history
  • Loading branch information
tanaya-mankad committed Jul 31, 2024
1 parent 8590971 commit 37ddbeb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ void CoilCoolingDXCurveFitOperatingMode::CalcOperatingMode(EnergyPlus::EnergyPlu
// Currently speedNum is 1-based, while this->speeds are zero-based
auto &thisspeed(this->speeds[max(speedNum - 1, 0)]);

if ((speedNum == 0) || ((speedNum == 1) && (speedRatio == 0.0)) || (inletNode.MassFlowRate == 0.0)) {
if ((speedNum == 1) && (speedRatio == 0.0) || (inletNode.MassFlowRate == 0.0)) {
outletNode.Temp = inletNode.Temp;
outletNode.HumRat = inletNode.HumRat;
outletNode.Enthalpy = inletNode.Enthalpy;
Expand Down

5 comments on commit 37ddbeb

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - Win64-Windows-10-VisualStudio-16: OK (2862 of 2863 tests passed, 0 test warnings)

Failures:\n

ZoneUnitarySysTest Test Summary

  • Passed: 27
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3674 of 3696 tests passed, 26 test warnings)

Messages:\n

  • 27 tests had: ERR diffs.
  • 19 tests had: EIO diffs.
  • 20 tests had: Table big diffs.
  • 21 tests had: Table string diffs.
  • 6 tests had: ESO small diffs.
  • 6 tests had: MTR small diffs.
  • 1 test had: EDD diffs.
  • 3 tests had: ESO big diffs.
  • 3 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Failures:\n

regression Test Summary

  • Passed: 790
  • Failed: 21

ZoneUnitarySysTest Test Summary

  • Passed: 27
  • Failed: 1

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-MacOS-10.18-clang-15.0.0: OK (3633 of 3655 tests passed, 26 test warnings)

Messages:\n

  • 27 tests had: ERR diffs.
  • 19 tests had: EIO diffs.
  • 20 tests had: Table big diffs.
  • 21 tests had: Table string diffs.
  • 6 tests had: ESO small diffs.
  • 6 tests had: MTR small diffs.
  • 1 test had: EDD diffs.
  • 3 tests had: ESO big diffs.
  • 3 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Failures:\n

regression Test Summary

  • Passed: 770
  • Failed: 21

ZoneUnitarySysTest Test Summary

  • Passed: 27
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2069 of 2071 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1576
  • Subprocess aborted: 1

ZoneUnitarySysTest Test Summary

  • Passed: 27
  • Subprocess aborted: 1

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (776 of 795 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 776
  • Failed: 19

Build Badge Test Badge Coverage Badge

Please sign in to comment.