Skip to content

Commit

Permalink
Revert CoilPLR to m_CoolingSpeedRatio.
Browse files Browse the repository at this point in the history
  • Loading branch information
tanaya-mankad committed Jan 29, 2024
1 parent 6d3cc5c commit 45ddc48
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/EnergyPlus/UnitarySystem.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11693,7 +11693,7 @@ namespace UnitarySystems {
}

state.dataCoilCooingDX->coilCoolingDXs[this->m_CoolingCoilIndex].simulate(
state, OperationMode, this->m_CoolingSpeedNum, CoilPLR, this->m_FanOpMode, singleMode, this->CoilSHR);
state, OperationMode, this->m_CoolingSpeedNum, this->m_CoolingSpeedRatio, this->m_FanOpMode, singleMode, this->CoilSHR);

if (this->m_CoolingSpeedNum > 1) {
if (this->m_SingleMode == 0) {
Expand Down

5 comments on commit 45ddc48

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3565 of 3586 tests passed, 1 test warnings)

Messages:\n

  • 17 tests had: EIO diffs.
  • 13 tests had: ERR diffs.
  • 16 tests had: ESO big diffs.
  • 19 tests had: Table big diffs.
  • 15 tests had: MTR big diffs.
  • 2 tests had: EDD diffs.
  • 1 test had: ESO small diffs.
  • 2 tests had: MTR small diffs.
  • 1 test had: Table small diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1484
  • Failed: 1

regression Test Summary

  • Passed: 787
  • Failed: 19

ZoneUnitarySysTest Test Summary

  • Passed: 26
  • Failed: 1

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - Win64-Windows-10-VisualStudio-16: OK (2756 of 2758 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1482
  • Failed: 1

ZoneUnitarySysTest Test Summary

  • Passed: 26
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1969 of 1971 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1484
  • Failed: 1

ZoneUnitarySysTest Test Summary

  • Passed: 26
  • Failed: 1

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-MacOS-10.18-clang-15.0.0: OK (3523 of 3545 tests passed, 1 test warnings)

Messages:\n

  • 17 tests had: EIO diffs.
  • 13 tests had: ERR diffs.
  • 16 tests had: ESO big diffs.
  • 19 tests had: Table big diffs.
  • 15 tests had: MTR big diffs.
  • 2 tests had: EDD diffs.
  • 1 test had: ESO small diffs.
  • 2 tests had: MTR small diffs.
  • 1 test had: Table small diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1484
  • Failed: 1

regression Test Summary

  • Passed: 767
  • Failed: 19

ZoneUnitarySysTest Test Summary

  • Passed: 26
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (788 of 790 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 788
  • Failed: 2

Build Badge Test Badge Coverage Badge

Please sign in to comment.