Skip to content

Commit

Permalink
Merge from remote.
Browse files Browse the repository at this point in the history
  • Loading branch information
tanaya-mankad committed Jul 22, 2024
2 parents cb92a78 + 374707a commit d4ac8d1
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 12 deletions.
4 changes: 3 additions & 1 deletion src/EnergyPlus/Coils/CoilCoolingDX.cc
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,8 @@ void CoilCoolingDX::simulate(EnergyPlusData &state,
bool const singleMode,
Real64 const LoadSHR)
{
assert(speedNum != 0);

if (this->myOneTimeInitFlag) {
this->oneTimeInit(state);
this->myOneTimeInitFlag = false;
Expand Down Expand Up @@ -769,7 +771,7 @@ void CoilCoolingDX::simulate(EnergyPlusData &state,
this->wasteHeatEnergyRate = this->performance.wasteHeatRate;
this->wasteHeatEnergy = this->performance.wasteHeatRate * reportingConstant;

this->partLoadRatioReport = speedNum == 1 ? 1.0 : speedRatio;
this->partLoadRatioReport = speedNum > 1 ? 1.0 : speedRatio;
this->speedNumReport = speedNum;
this->speedRatioReport = speedRatio;

Expand Down
21 changes: 11 additions & 10 deletions src/EnergyPlus/UnitarySystem.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11537,24 +11537,25 @@ namespace UnitarySystems {
} break;
case HVAC::CoilDX_Cooling: { // CoilCoolingDX
bool const singleMode = (this->m_SingleMode == 1);
CoilPLR = 0.0;
if (this->m_ControlType == UnitarySysCtrlType::Setpoint) {
if (CompressorOn == HVAC::CompressorOp::On) {
CoilPLR = (this->m_CoolingSpeedNum > 1) ? 1.0 : PartLoadRatio;
} else
CoilPLR = 0.0;
}
} else {
if (this->m_EMSOverrideCoilSpeedNumOn) {
CoilPLR = this->m_CoolingSpeedRatio;
} else {
if (CompressorOn == HVAC::CompressorOp::Off) {
this->m_CoolingSpeedNum = 1; // Bypass mixed-speed calculations in called functions
CoilPLR = 0.0;
} else {
if (singleMode) {
CoilPLR = (m_CoolingSpeedNum == 1) ? PartLoadRatio
: 0.0; // singleMode allows cycling, but not part load operation at higher speeds
if (state.dataUnitarySystems->CoolingLoad) {
if (CompressorOn == HVAC::CompressorOp::Off) {
this->m_CoolingSpeedNum = 1; // Bypass mixed-speed calculations in called functions
} else {
CoilPLR = PartLoadRatio;
if (singleMode) {
CoilPLR = (m_CoolingSpeedNum == 1) ? PartLoadRatio
: 0.0; // singleMode allows cycling, but not part load operation at higher speeds
} else {
CoilPLR = PartLoadRatio;
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/UnitarySystem.hh
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ namespace UnitarySystems {

Real64 m_CoolingCycRatio = 0.0;
Real64 m_CoolingSpeedRatio = 0.0;
int m_CoolingSpeedNum = 0;
int m_CoolingSpeedNum = 1;

int m_EconoSpeedNum = 0;
Real64 m_EconoPartLoadRatio = 0;
Expand Down

2 comments on commit d4ac8d1

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - x86_64-MacOS-10.18-clang-15.0.0: Build Failed

Messages:\n

  • 6 tests had: ESO small diffs.
  • 6 tests had: MTR small diffs.
  • 3 tests had: ERR diffs.
  • 1 test had: EDD diffs.
  • 4 tests had: Table big diffs.
  • 5 tests had: Table string diffs.
  • 6 tests had: EIO diffs.
  • 3 tests had: ESO big diffs.
  • 3 tests had: MTR big diffs.
  • 3 tests had: Table small diffs.

Failures:\n

regression Test Summary

  • Passed: 785
  • Failed: 6

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-coil-load-ratios (bigladder) - Win64-Windows-10-VisualStudio-16: OK (2854 of 2854 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.