Skip to content

Commit

Permalink
Bypass simulation when speed == 0; restore init value of speed.
Browse files Browse the repository at this point in the history
  • Loading branch information
@tanaya-mankad
tanaya-mankad committed Feb 21, 2024
1 parent 11ca749 commit dd0f15b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ void CoilCoolingDXCurveFitOperatingMode::CalcOperatingMode(EnergyPlus::EnergyPlu
// Currently speedNum is 1-based, while this->speeds are zero-based
auto &thisspeed(this->speeds[max(speedNum - 1, 0)]);

if (((speedNum == 1) && (PLR == 0.0)) || (inletNode.MassFlowRate == 0.0)) {
if ((speedNum == 0) || ((speedNum == 1) && (PLR == 0.0)) || (inletNode.MassFlowRate == 0.0)) {
outletNode.Temp = inletNode.Temp;
outletNode.HumRat = inletNode.HumRat;
outletNode.Enthalpy = inletNode.Enthalpy;
Expand Down

5 comments on commit dd0f15b

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonzero-cooling-speed-num (bigladder) - Win64-Windows-10-VisualStudio-16: OK (2766 of 2766 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonzero-cooling-speed-num (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3567 of 3595 tests passed, 14 test warnings)

Messages:\n

  • 25 tests had: AUD diffs.
  • 22 tests had: EIO diffs.
  • 30 tests had: ESO small diffs.
  • 21 tests had: MTR small diffs.
  • 28 tests had: Table big diffs.
  • 5 tests had: RDD diffs.
  • 13 tests had: Table small diffs.
  • 1 test had: ERR diffs.
  • 2 tests had: EDD diffs.
  • 3 tests had: IDF diffs.

Failures:\n

regression Test Summary

  • Passed: 779
  • Failed: 28

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonzero-cooling-speed-num (bigladder) - x86_64-MacOS-10.18-clang-15.0.0: OK (3526 of 3554 tests passed, 14 test warnings)

Messages:\n

  • 25 tests had: AUD diffs.
  • 22 tests had: EIO diffs.
  • 30 tests had: ESO small diffs.
  • 21 tests had: MTR small diffs.
  • 27 tests had: Table big diffs.
  • 5 tests had: RDD diffs.
  • 11 tests had: Table small diffs.
  • 1 test had: EDD diffs.
  • 3 tests had: IDF diffs.

Failures:\n

regression Test Summary

  • Passed: 760
  • Failed: 27

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonzero-cooling-speed-num (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1978 of 1978 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonzero-cooling-speed-num (bigladder) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (791 of 791 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.