Enable optional chaining by default in @babel/parser (babel#10817)

bigospolski · Jan 10, 2020 · 5f807ae · 5f807ae
1 parent 646409b
commit 5f807ae
Show file tree

Hide file tree

Showing 48 changed files with 5 additions and 50 deletions.
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -587,7 +587,6 @@ export default class ExpressionParser extends LValParser {
     }
     let optional = false;
     if (this.match(tt.questionDot)) {
-      this.expectPlugin("optionalChaining");
       state.optionalChainMember = optional = true;
       if (noCalls && this.lookaheadCharCode() === charCodes.leftParenthesis) {
         state.stop = true;

diff --git a/packages/babel-parser/src/plugins/flow.js b/packages/babel-parser/src/plugins/flow.js
@@ -2801,7 +2801,6 @@ export default (superClass: Class<Parser>): Class<Parser> =>
       subscriptState: N.ParseSubscriptState,
     ): N.Expression {
       if (this.match(tt.questionDot) && this.isLookaheadRelational("<")) {
-        this.expectPlugin("optionalChaining");
         subscriptState.optionalChainMember = true;
         if (noCalls) {
           subscriptState.stop = true;

diff --git a/...l-chaining/class-contructor-call/input.js → ...l-chaining/class-contructor-call/input.js b/...l-chaining/class-contructor-call/input.js → ...l-chaining/class-contructor-call/input.js
diff --git a/...haining/class-contructor-call/output.json → ...haining/class-contructor-call/output.json b/...haining/class-contructor-call/output.json → ...haining/class-contructor-call/output.json
diff --git a/...nal-chaining/conditional-decimal/input.js → ...nal-chaining/conditional-decimal/input.js b/...nal-chaining/conditional-decimal/input.js → ...nal-chaining/conditional-decimal/input.js
diff --git a/...-chaining/conditional-decimal/output.json → ...-chaining/conditional-decimal/output.json b/...-chaining/conditional-decimal/output.json → ...-chaining/conditional-decimal/output.json
diff --git a/.../optional-chaining/function-call/input.js → .../optional-chaining/function-call/input.js b/.../optional-chaining/function-call/input.js → .../optional-chaining/function-call/input.js
diff --git a/...tional-chaining/function-call/output.json → ...tional-chaining/function-call/output.json b/...tional-chaining/function-call/output.json → ...tional-chaining/function-call/output.json
diff --git a/...l-chaining/member-access-bracket/input.js → ...l-chaining/member-access-bracket/input.js b/...l-chaining/member-access-bracket/input.js → ...l-chaining/member-access-bracket/input.js
diff --git a/...haining/member-access-bracket/output.json → ...haining/member-access-bracket/output.json b/...haining/member-access-bracket/output.json → ...haining/member-access-bracket/output.json
diff --git a/.../optional-chaining/member-access/input.js → .../optional-chaining/member-access/input.js b/.../optional-chaining/member-access/input.js → .../optional-chaining/member-access/input.js
diff --git a/...tional-chaining/member-access/output.json → ...tional-chaining/member-access/output.json b/...tional-chaining/member-access/output.json → ...tional-chaining/member-access/output.json
diff --git a/...aining/optioanl-chain-expression/input.js → ...aining/optioanl-chain-expression/input.js b/...aining/optioanl-chain-expression/input.js → ...aining/optioanl-chain-expression/input.js
diff --git a/...ing/optioanl-chain-expression/output.json → ...ing/optioanl-chain-expression/output.json b/...ing/optioanl-chain-expression/output.json → ...ing/optioanl-chain-expression/output.json
diff --git a/...al-chaining/optional-constructor/input.js → ...al-chaining/optional-constructor/input.js b/...al-chaining/optional-constructor/input.js → ...al-chaining/optional-constructor/input.js
diff --git a/...chaining/optional-constructor/output.json → ...chaining/optional-constructor/output.json b/...chaining/optional-constructor/output.json → ...chaining/optional-constructor/output.json
diff --git a/...ng/optional-super-property-class/input.js → ...ng/optional-super-property-class/input.js b/...ng/optional-super-property-class/input.js → ...ng/optional-super-property-class/input.js
diff --git a/...optional-super-property-class/output.json → ...optional-super-property-class/output.json b/...optional-super-property-class/output.json → ...optional-super-property-class/output.json
diff --git a/...chaining/optional-super-property/input.js → ...chaining/optional-super-property/input.js b/...chaining/optional-super-property/input.js → ...chaining/optional-super-property/input.js
diff --git a/...ining/optional-super-property/output.json → ...ining/optional-super-property/output.json b/...ining/optional-super-property/output.json → ...ining/optional-super-property/output.json
diff --git a/...ptional-tagged-template-literals/input.js → ...ptional-tagged-template-literals/input.js b/...ptional-tagged-template-literals/input.js → ...ptional-tagged-template-literals/input.js
diff --git a/...onal-tagged-template-literals/output.json → ...onal-tagged-template-literals/output.json b/...onal-tagged-template-literals/output.json → ...onal-tagged-template-literals/output.json
diff --git a/...ional-chaining/parenthised-chain/input.js → ...ional-chaining/parenthised-chain/input.js b/...ional-chaining/parenthised-chain/input.js → ...ional-chaining/parenthised-chain/input.js
diff --git a/...al-chaining/parenthised-chain/output.json → ...al-chaining/parenthised-chain/output.json b/...al-chaining/parenthised-chain/output.json → ...al-chaining/parenthised-chain/output.json
diff --git a/...onal-chaining/separated-chaining/input.js → ...onal-chaining/separated-chaining/input.js b/...onal-chaining/separated-chaining/input.js → ...onal-chaining/separated-chaining/input.js
diff --git a/...l-chaining/separated-chaining/output.json → ...l-chaining/separated-chaining/output.json b/...l-chaining/separated-chaining/output.json → ...l-chaining/separated-chaining/output.json
diff --git a/...onal-chaining/super-method-class/input.js → ...onal-chaining/super-method-class/input.js b/...onal-chaining/super-method-class/input.js → ...onal-chaining/super-method-class/input.js
diff --git a/...l-chaining/super-method-class/output.json → ...l-chaining/super-method-class/output.json b/...l-chaining/super-method-class/output.json → ...l-chaining/super-method-class/output.json
diff --git a/packages/babel-parser/test/fixtures/experimental/_no-plugin/optional-chaining/input.js b/packages/babel-parser/test/fixtures/experimental/_no-plugin/optional-chaining/input.js
diff --git a/packages/babel-parser/test/fixtures/experimental/_no-plugin/optional-chaining/options.json b/packages/babel-parser/test/fixtures/experimental/_no-plugin/optional-chaining/options.json
diff --git a/...el-parser/test/fixtures/experimental/optional-chaining/class-contructor-call/options.json b/...el-parser/test/fixtures/experimental/optional-chaining/class-contructor-call/options.json
diff --git a/...abel-parser/test/fixtures/experimental/optional-chaining/conditional-decimal/options.json b/...abel-parser/test/fixtures/experimental/optional-chaining/conditional-decimal/options.json
diff --git a/...ages/babel-parser/test/fixtures/experimental/optional-chaining/function-call/options.json b/...ages/babel-parser/test/fixtures/experimental/optional-chaining/function-call/options.json
diff --git a/...el-parser/test/fixtures/experimental/optional-chaining/member-access-bracket/options.json b/...el-parser/test/fixtures/experimental/optional-chaining/member-access-bracket/options.json
diff --git a/...ages/babel-parser/test/fixtures/experimental/optional-chaining/member-access/options.json b/...ages/babel-parser/test/fixtures/experimental/optional-chaining/member-access/options.json
diff --git a/...arser/test/fixtures/experimental/optional-chaining/optioanl-chain-expression/options.json b/...arser/test/fixtures/experimental/optional-chaining/optioanl-chain-expression/options.json
diff --git a/...bel-parser/test/fixtures/experimental/optional-chaining/optional-constructor/options.json b/...bel-parser/test/fixtures/experimental/optional-chaining/optional-constructor/options.json
diff --git a/...r/test/fixtures/experimental/optional-chaining/optional-super-property-class/options.json b/...r/test/fixtures/experimental/optional-chaining/optional-super-property-class/options.json
diff --git a/...-parser/test/fixtures/experimental/optional-chaining/optional-super-property/options.json b/...-parser/test/fixtures/experimental/optional-chaining/optional-super-property/options.json
diff --git a/...st/fixtures/experimental/optional-chaining/optional-tagged-template-literals/options.json b/...st/fixtures/experimental/optional-chaining/optional-tagged-template-literals/options.json
diff --git a/.../babel-parser/test/fixtures/experimental/optional-chaining/parenthised-chain/options.json b/.../babel-parser/test/fixtures/experimental/optional-chaining/parenthised-chain/options.json
diff --git a/...babel-parser/test/fixtures/experimental/optional-chaining/separated-chaining/options.json b/...babel-parser/test/fixtures/experimental/optional-chaining/separated-chaining/options.json
diff --git a/...babel-parser/test/fixtures/experimental/optional-chaining/super-method-class/options.json b/...babel-parser/test/fixtures/experimental/optional-chaining/super-method-class/options.json
diff --git a/packages/babel-parser/test/fixtures/flow/typeapp-call/function-call-optional/options.json b/packages/babel-parser/test/fixtures/flow/typeapp-call/function-call-optional/options.json
@@ -1,3 +1,3 @@
 {
-  "plugins": ["jsx", "flow", "optionalChaining"]
+  "plugins": ["jsx", "flow"]
 }
diff --git a/packages/babel-parser/test/fixtures/flow/typeapp-call/method-call-optional/options.json b/packages/babel-parser/test/fixtures/flow/typeapp-call/method-call-optional/options.json
@@ -1,3 +1,3 @@
 {
-  "plugins": ["jsx", "flow", "optionalChaining"]
+  "plugins": ["jsx", "flow"]
 }
diff --git a/packages/babel-parser/test/fixtures/flow/typeapp-call/method-call-optional2/options.json b/packages/babel-parser/test/fixtures/flow/typeapp-call/method-call-optional2/options.json
@@ -1,3 +1,3 @@
 {
-  "plugins": ["jsx", "flow", "optionalChaining"]
+  "plugins": ["jsx", "flow"]
 }
diff --git a/packages/babel-parser/test/fixtures/typescript/optional-chaining/type-arguments/options.json b/packages/babel-parser/test/fixtures/typescript/optional-chaining/type-arguments/options.json
@@ -1,4 +1,4 @@
 {
   "sourceType": "module",
-  "plugins": ["typescript", "optionalChaining"]
+  "plugins": ["typescript"]
 }
diff --git a/...ages/babel-parser/test/fixtures/v8intrinsic/_errors/optional-call-expression/options.json b/...ages/babel-parser/test/fixtures/v8intrinsic/_errors/optional-call-expression/options.json
@@ -1,4 +1,4 @@
 {
-  "plugins": ["optionalChaining", "v8intrinsic"],
+  "plugins": ["v8intrinsic"],
   "throws": "Unexpected token (1:0)"
 }