Update source code to work with OSGi environment #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi bigpuritz ! The first , thanks for your public source code ,this very useful to my work .
I've been used this source code to implement the Netty + Servlet API in OSGi environment , it work greate for me with a litlte bit of changes .I will be show you what I need and what I changed with netty-servlet-brigde
I change a litle of source code to make it work with my require ,detail is following:
Adding getter/setter for 'servlets' in net.javaforge.netty.servlet.bridge.config.WebappConfiguration
Update net.javaforge.netty.servlet.bridge.impl.ServletBridgeWebapp constructor visibility to public
When the server started , if new servlet is added at runtime , you need to initialized it ,so I get the servlets and :
1.Check if servlet handler contains a servlet which same as new servlet added then remove it
2.Adding servlet to servlet handler . I'm using :
3.Initialized servlet using ServletBridgeWebapp
Now ,when you adding new servlet or modified the existence , servlet handler will re-adding and initializing it for you
That's all i need to show you about my change , if you have the greater way to accomplished that ,please show me these
Please consider to this pull issue and sorry about my English
Many thanks !