This repository has been archived by the owner on Jul 14, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Testing if an element has focus with
is(':focus')
can be very frustrating in a local environment. If a user happens to click away from the browser window while they're running a test suite, assertions usingis(':focus')
will fail.Meant to address https://github.com/bigtestjs/interactor/issues/62
Approach
Introduce
isFocused()
that matches ondocument.activeElement
under the hood instead of the:focus
pseudo class.Next steps
Will need a minor release and updates to https://github.com/bigtestjs/bigtestjs.io.