Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Default Footer implementation (#33) #35

Merged
merged 2 commits into from
Sep 4, 2023
Merged

feat: Default Footer implementation (#33) #35

merged 2 commits into from
Sep 4, 2023

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Sep 4, 2023 •
edited
Loading

Tasks:

  • Create default footer
  • Move version information into footer

@gromdimon gromdimon linked an issue Sep 4, 2023 that may be closed by this pull request
Move version information into footer #33
Closed
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #35 (0f83058) into main (6043aec) will increase coverage by 48.48%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
+ Coverage   38.79%   87.27%   +48.48%     
===========================================
  Files          30        2       -28     
  Lines        1026       55      -971     
  Branches      325        0      -325     
===========================================
- Hits          398       48      -350     
+ Misses        550        7      -543     
+ Partials       78        0       -78

see 28 files with indirect coverage changes

@gromdimon gromdimon enabled auto-merge (squash) September 4, 2023 10:34
@gromdimon gromdimon disabled auto-merge September 4, 2023 10:34
@gromdimon gromdimon merged commit ef6549a into main Sep 4, 2023
@gromdimon gromdimon deleted the 33-move-version-information-into-footer branch September 4, 2023 10:36
@varfish-bot varfish-bot mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move version information into footer
1 participant
@gromdimon