Make routeLineclipping robust to malformed gtfs #36
Conversation
|
Deployed onto staging, seems to be working well! |
src/lib/route-linestring.js
Outdated
| const shapeIdsForRoute = stopTripShapeLookup[routeId]; | ||
|
|
||
| if (shapeIdsForRoute) { |
There was a problem hiding this comment.
Isn't this the only thing that could be undefined, therefore doesn't this check make the catch-all around everything unnecessary?
There was a problem hiding this comment.
lineSlice can throw if any of the input is malformed in any way. A linestring that's a single point for example.
Since this part of the code deals with data parsed from the gtfs files which don't have a strict schema, I like having this safety net.
A much more elegant solution would be doing schema validation on the ingested dictionaries, but eh, thats way too much work for some data that needs to only be used in one function.
There was a problem hiding this comment.
Can you put the try/catch around just the lineSlice call then?
There was a problem hiding this comment.
sure, I wrapped all the turf punctions though coz all of them have some validation
Added and null check and wrapped it in a
try..catch🤷🏽