Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap to streets, not separately-mapped sidewalks #74

Closed
graue opened this issue Apr 24, 2022 · 4 comments · Fixed by #148
Closed

Snap to streets, not separately-mapped sidewalks #74

graue opened this issue Apr 24, 2022 · 4 comments · Fixed by #148
Assignees
Labels
feature not a bug

Comments

@graue
Copy link

graue commented Apr 24, 2022

When sidewalks are mapped separately on OSM, the router's directions start out in a needlessly confusing and awkward way, for example in these instructions starting from a randomly chosen address on Shotwell Street in SF:

image

First 3 instructions:

  1. Continue [translated by the UI I've built into "Head north"]
  2. Turn right
  3. Turn right onto Shotwell Street

After this, the instructions are normal. But people are going to be confused by the first two instructions referring to unnamed pathways (which are in fact the Shotwell Street sidewalk and the 19th Street sidewalk, respectively). The instructions should just begin with:

  1. Head south on Shotwell Street
@graue
Copy link
Author

graue commented May 12, 2022

Related issue: we're producing this inscrutable set of directions for crossing the street where just "Get off at 24th St & Mission St, Board BART at 24th Street / Mission" would be plenty of information:

image

image

@hcourt hcourt added the feature not a bug label Aug 5, 2022
@graue
Copy link
Author

graue commented Jun 6, 2023

I wonder if we could solve this by just not snapping to a way tagged with footway=sidewalk, since, in those cases, there should always be a nearby way that represents the street.

@Andykmcc
Copy link

there is a snap_preventions option that lets you provide a list of ways. its ref'd in this issue and i've seen in in other docs over the last week. my gut says we can add this to our profile in the config.yml

@rsarathy rsarathy self-assigned this May 21, 2024
@rsarathy
Copy link

Graphhopper's provided snap_preventions and SnapPreventionEdgeFilter APIs only work for non-PT profiles. I'm working on incorporating the SnapPreventionEdgeFilter into our PT routing methods.

@rsarathy rsarathy linked a pull request May 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature not a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants