GH# 74: Snap to streets #148
Conversation
|
|
There was a problem hiding this comment.
Would it have been harder to just avoid footway=sidewalk?
I suggested that in case there are some footways we might want to use. On the other hand, this is probably fine. Looking at the footway wiki page it's mostly sidewalk-like things and (for example) the O'Shaughnessy Blvd sidepath is tagged highway=path instead, so it's NBD.
| final Snap closest = locationIndex.findClosest(point.lat, point.lon, snapFilters.get(i)); | ||
| EdgeFilter mergedFilter = new SnapPreventionEdgeFilter( | ||
| snapFilters.get(i), roadClassEnc, roadEnvEnc, | ||
| Collections.singletonList("footway")); |
There was a problem hiding this comment.
Would we still want to snap to sidewalks for public transit directions with walking as the connecting mode? Probably, right? If so, this should test for the connecting mode. Not currently relevant but matters when we add a transit/no bike directions mode or want to merge changes upstream.
There was a problem hiding this comment.
Makes sense. Let me try and implement this at the config-level, using a snap_preventions field underneath our bike2 profile.
There was a problem hiding this comment.
Done, this is now handled via our configs. We can specify snap_preventions as a comma-separated list.
I'm not sure right now how difficult this will be to implement, but I'll investigate it in a separate PR. I see that you opened #123, which captures this ask. |
|
#123 is different. That issue is about discouraging routing on sidewalks, not about preventing snapping to them for the start point of a route. |
No description provided.