Skip to content

Commit

Permalink
Fix: Remove prefix from test suite names (#25)
Browse files Browse the repository at this point in the history
# Description

- Remove redundant 'BikeIndex' prefix from Unit Test and UI Test suite
names

### Screenshots

<img
src="https://github.com/user-attachments/assets/1f5b90d3-46b6-4cad-b12c-f1add611e51a"
alt="Scene from 'The Social Network' when investor Sean Parker says
'Drop the _the_, just _facebook_ it's cleaner'">
  • Loading branch information
aokj4ck authored Feb 22, 2025
1 parent 9bc2f0a commit 926215b
Show file tree
Hide file tree
Showing 24 changed files with 70 additions and 70 deletions.
74 changes: 37 additions & 37 deletions BikeIndex.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
0496C6712CB36BF100B88D1B /* .ruby-version */ = {isa = PBXFileReference; lastKnownFileType = text; path = ".ruby-version"; sourceTree = "<group>"; };
0496C6722CB36BF600B88D1B /* Gemfile */ = {isa = PBXFileReference; explicitFileType = text.script.ruby; path = Gemfile; sourceTree = "<group>"; };
04F4B8F72B098ADB009442B5 /* BikeIndex.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = BikeIndex.app; sourceTree = BUILT_PRODUCTS_DIR; };
04F4B90A2B098ADE009442B5 /* BikeIndexTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BikeIndexTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
04F4B9142B098ADE009442B5 /* BikeIndexUITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BikeIndexUITests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
04F4B90A2B098ADE009442B5 /* UnitTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = UnitTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
04F4B9142B098ADE009442B5 /* UITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = UITests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
04F4B9272B098B44009442B5 /* BikeIndex-production.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = "BikeIndex-production.xcconfig"; sourceTree = "<group>"; };
04F4B9282B098B44009442B5 /* BikeIndex-template.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = "BikeIndex-template.xcconfig"; sourceTree = "<group>"; };
04F4B9292B098B44009442B5 /* BikeIndex-development.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = "BikeIndex-development.xcconfig"; sourceTree = "<group>"; };
Expand All @@ -78,35 +78,35 @@
membershipExceptions = (
"Debug (bikeindex.org).xctestplan",
);
target = 04F4B9092B098ADE009442B5 /* BikeIndexTests */;
target = 04F4B9092B098ADE009442B5 /* UnitTests */;
};
04CDF16A2D3C344800F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
membershipExceptions = (
Info.plist,
);
target = 04F4B9132B098ADE009442B5 /* BikeIndexUITests */;
target = 04F4B9132B098ADE009442B5 /* UITests */;
};
04CDF1722D3C344C00F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
membershipExceptions = (
"Logger+Tests.swift",
);
target = 04F4B9092B098ADE009442B5 /* BikeIndexTests */;
target = 04F4B9092B098ADE009442B5 /* UnitTests */;
};
04CDF1732D3C344C00F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
membershipExceptions = (
"Logger+Tests.swift",
);
target = 04F4B9132B098ADE009442B5 /* BikeIndexUITests */;
target = 04F4B9132B098ADE009442B5 /* UITests */;
};
/* End PBXFileSystemSynchronizedBuildFileExceptionSet section */

/* Begin PBXFileSystemSynchronizedRootGroup section */
04CDF1012D3C344100F90515 /* BikeIndex */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (04CDF1442D3C344100F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = BikeIndex; sourceTree = "<group>"; };
04CDF1502D3C344500F90515 /* BikeIndexTests */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (04CDF15C2D3C344500F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = BikeIndexTests; sourceTree = "<group>"; };
04CDF1632D3C344800F90515 /* BikeIndexUITests */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (04CDF16A2D3C344800F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = BikeIndexUITests; sourceTree = "<group>"; };
04CDF1502D3C344500F90515 /* UnitTests */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (04CDF15C2D3C344500F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = UnitTests; sourceTree = "<group>"; };
04CDF1632D3C344800F90515 /* UITests */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (04CDF16A2D3C344800F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = UITests; sourceTree = "<group>"; };
04CDF16F2D3C344C00F90515 /* SharedTests */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (04CDF1722D3C344C00F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, 04CDF1732D3C344C00F90515 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = SharedTests; sourceTree = "<group>"; };
/* End PBXFileSystemSynchronizedRootGroup section */

Expand Down Expand Up @@ -158,8 +158,8 @@
04F4B9272B098B44009442B5 /* BikeIndex-production.xcconfig */,
04F4B9282B098B44009442B5 /* BikeIndex-template.xcconfig */,
04CDF1012D3C344100F90515 /* BikeIndex */,
04CDF1502D3C344500F90515 /* BikeIndexTests */,
04CDF1632D3C344800F90515 /* BikeIndexUITests */,
04CDF1502D3C344500F90515 /* UnitTests */,
04CDF1632D3C344800F90515 /* UITests */,
04CDF16F2D3C344C00F90515 /* SharedTests */,
0496C6702CB36BED00B88D1B /* Brewfile */,
0496C6722CB36BF600B88D1B /* Gemfile */,
Expand All @@ -173,8 +173,8 @@
isa = PBXGroup;
children = (
04F4B8F72B098ADB009442B5 /* BikeIndex.app */,
04F4B90A2B098ADE009442B5 /* BikeIndexTests.xctest */,
04F4B9142B098ADE009442B5 /* BikeIndexUITests.xctest */,
04F4B90A2B098ADE009442B5 /* UnitTests.xctest */,
04F4B9142B098ADE009442B5 /* UITests.xctest */,
);
name = Products;
sourceTree = "<group>";
Expand Down Expand Up @@ -209,9 +209,9 @@
productReference = 04F4B8F72B098ADB009442B5 /* BikeIndex.app */;
productType = "com.apple.product-type.application";
};
04F4B9092B098ADE009442B5 /* BikeIndexTests */ = {
04F4B9092B098ADE009442B5 /* UnitTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 04F4B9212B098ADE009442B5 /* Build configuration list for PBXNativeTarget "BikeIndexTests" */;
buildConfigurationList = 04F4B9212B098ADE009442B5 /* Build configuration list for PBXNativeTarget "UnitTests" */;
buildPhases = (
04F4B9062B098ADE009442B5 /* Sources */,
04F4B9072B098ADE009442B5 /* Frameworks */,
Expand All @@ -223,16 +223,16 @@
04F4B90C2B098ADE009442B5 /* PBXTargetDependency */,
);
fileSystemSynchronizedGroups = (
04CDF1502D3C344500F90515 /* BikeIndexTests */,
04CDF1502D3C344500F90515 /* UnitTests */,
);
name = BikeIndexTests;
productName = BikeIndexTests;
productReference = 04F4B90A2B098ADE009442B5 /* BikeIndexTests.xctest */;
name = UnitTests;
productName = UnitTests;
productReference = 04F4B90A2B098ADE009442B5 /* UnitTests.xctest */;
productType = "com.apple.product-type.bundle.unit-test";
};
04F4B9132B098ADE009442B5 /* BikeIndexUITests */ = {
04F4B9132B098ADE009442B5 /* UITests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 04F4B9242B098ADE009442B5 /* Build configuration list for PBXNativeTarget "BikeIndexUITests" */;
buildConfigurationList = 04F4B9242B098ADE009442B5 /* Build configuration list for PBXNativeTarget "UITests" */;
buildPhases = (
04F4B9102B098ADE009442B5 /* Sources */,
04F4B9112B098ADE009442B5 /* Frameworks */,
Expand All @@ -245,11 +245,11 @@
04F4B9162B098ADE009442B5 /* PBXTargetDependency */,
);
fileSystemSynchronizedGroups = (
04CDF1632D3C344800F90515 /* BikeIndexUITests */,
04CDF1632D3C344800F90515 /* UITests */,
);
name = BikeIndexUITests;
productName = BikeIndexUITests;
productReference = 04F4B9142B098ADE009442B5 /* BikeIndexUITests.xctest */;
name = UITests;
productName = UITests;
productReference = 04F4B9142B098ADE009442B5 /* UITests.xctest */;
productType = "com.apple.product-type.bundle.ui-testing";
};
/* End PBXNativeTarget section */
Expand Down Expand Up @@ -295,8 +295,8 @@
projectRoot = "";
targets = (
04F4B8F62B098ADB009442B5 /* BikeIndex */,
04F4B9092B098ADE009442B5 /* BikeIndexTests */,
04F4B9132B098ADE009442B5 /* BikeIndexUITests */,
04F4B9092B098ADE009442B5 /* UnitTests */,
04F4B9132B098ADE009442B5 /* UITests */,
);
};
/* End PBXProject section */
Expand Down Expand Up @@ -478,7 +478,7 @@
DEAD_CODE_STRIPPING = YES;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.BikeIndexTests;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.UnitTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand All @@ -499,9 +499,9 @@
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = BikeIndexUITests/Info.plist;
INFOPLIST_FILE = UITests/Info.plist;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.BikeIndexUITests;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.UITests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand Down Expand Up @@ -724,7 +724,7 @@
DEAD_CODE_STRIPPING = YES;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.BikeIndexTests;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.UnitTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand All @@ -745,7 +745,7 @@
DEAD_CODE_STRIPPING = YES;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.BikeIndexTests;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.UnitTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand All @@ -766,9 +766,9 @@
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = BikeIndexUITests/Info.plist;
INFOPLIST_FILE = UITests/Info.plist;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.BikeIndexUITests;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.UITests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand All @@ -789,9 +789,9 @@
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = BikeIndexUITests/Info.plist;
INFOPLIST_FILE = UITests/Info.plist;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.BikeIndexUITests;
PRODUCT_BUNDLE_IDENTIFIER = org.bikeindex.UITests;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = auto;
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand Down Expand Up @@ -826,7 +826,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
04F4B9212B098ADE009442B5 /* Build configuration list for PBXNativeTarget "BikeIndexTests" */ = {
04F4B9212B098ADE009442B5 /* Build configuration list for PBXNativeTarget "UnitTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
04F4B9222B098ADE009442B5 /* Debug (development) */,
Expand All @@ -836,7 +836,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
04F4B9242B098ADE009442B5 /* Build configuration list for PBXNativeTarget "BikeIndexUITests" */ = {
04F4B9242B098ADE009442B5 /* Build configuration list for PBXNativeTarget "UITests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
04F4B9252B098ADE009442B5 /* Debug (development) */,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
shouldUseLaunchSchemeArgsEnv = "YES">
<TestPlans>
<TestPlanReference
reference = "container:BikeIndexTests/Debug (bikeindex.org).xctestplan"
reference = "container:UnitTests/Debug (bikeindex.org).xctestplan"
default = "YES">
</TestPlanReference>
</TestPlans>
Expand All @@ -40,8 +40,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "04F4B9092B098ADE009442B5"
BuildableName = "BikeIndexTests.xctest"
BlueprintName = "BikeIndexTests"
BuildableName = "UnitTests.xctest"
BlueprintName = "UnitTests"
ReferencedContainer = "container:BikeIndex.xcodeproj">
</BuildableReference>
<SkippedTests>
Expand All @@ -59,8 +59,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "04F4B9132B098ADE009442B5"
BuildableName = "BikeIndexUITests.xctest"
BlueprintName = "BikeIndexUITests"
BuildableName = "UITests.xctest"
BlueprintName = "UITests"
ReferencedContainer = "container:BikeIndex.xcodeproj">
</BuildableReference>
</TestableReference>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "04F4B9092B098ADE009442B5"
BuildableName = "BikeIndexTests.xctest"
BlueprintName = "BikeIndexTests"
BuildableName = "UnitTests.xctest"
BlueprintName = "UnitTests"
ReferencedContainer = "container:BikeIndex.xcodeproj">
</BuildableReference>
</TestableReference>
Expand All @@ -50,8 +50,8 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "04F4B9132B098ADE009442B5"
BuildableName = "BikeIndexUITests.xctest"
BlueprintName = "BikeIndexUITests"
BuildableName = "UITests.xctest"
BlueprintName = "UITests"
ReferencedContainer = "container:BikeIndex.xcodeproj">
</BuildableReference>
</TestableReference>
Expand Down
2 changes: 1 addition & 1 deletion BikeIndex/Model/MockData.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// MockData.swift
// BikeIndexTests
// UnitTests
//
// Created by Jack on 11/26/23.
//
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ Running UI Tests from Xcode may cache logged-in state. Set up a credentials xcco
2. Edit the source to add a test username and password that are valid credentials for the server configured by corresponding build scheme (see: BikeIndex-development.xcconfig) you'll be using.
- This test account must have already authorized the Bike Index OAuth app used in your corresponding build scheme's .xcconfig.
3. In the simulator erase all content and settings to clear out any previous credentials.
4. Run the UI tests through Xcode or `bundle exec fastlane scan --only-testing "BikeIndexUITests"`!
4. Run the UI tests through Xcode or `bundle exec fastlane scan --only-testing "UITests"`!

##### Run an individual test case

Fastlane scan can run a single test case such as: `bundle exec fastlane scan --only-testing "BikeIndexUITests/ManufacturerKeyboardUITestCase"`.
Fastlane scan can run a single test case such as: `bundle exec fastlane scan --only-testing "UITests/ManufacturerKeyboardUITestCase"`.

## Sponsorship

Expand Down
4 changes: 2 additions & 2 deletions SharedTests/AllTests.xctestplan
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"target" : {
"containerPath" : "container:BikeIndex.xcodeproj",
"identifier" : "04F4B9092B098ADE009442B5",
"name" : "BikeIndexTests"
"name" : "UnitTests"
}
},
{
Expand All @@ -35,7 +35,7 @@
"target" : {
"containerPath" : "container:BikeIndex.xcodeproj",
"identifier" : "04F4B9132B098ADE009442B5",
"name" : "BikeIndexUITests"
"name" : "UITests"
}
}
],
Expand Down
2 changes: 1 addition & 1 deletion SharedTests/Logger+Tests.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// Logger+Tests.swift
// BikeIndexTests
// UnitTests
//
// Created by Jack on 11/26/23.
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// AuthenticatedUITestCase.swift
// BikeIndexUITests
// UITests
//
// Created by Jack on 12/4/24.
//
Expand Down Expand Up @@ -44,7 +44,7 @@ extension XCTestCase {
let timeout: TimeInterval = 120

// Configure these values in SharedTests/Test-credentials.xcconfig (see adjacent template file)
let uiTestBundle = try XCTUnwrap(Bundle(identifier: "org.bikeindex.BikeIndexUITests"))
let uiTestBundle = try XCTUnwrap(Bundle(identifier: "org.bikeindex.UITests"))
let infoDictionary = try XCTUnwrap(uiTestBundle.infoDictionary)
let testUsername = try XCTUnwrap(infoDictionary["TEST_USERNAME"] as? String)
let testPassword = try XCTUnwrap(infoDictionary["TEST_PASSWORD"] as? String)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// BikeIndexUITests.swift
// BikeIndexUITests
// UITests
//
// Created by Jack on 11/18/23.
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// BikeIndexUITestsLaunchTests.swift
// BikeIndexUITests
// UITests
//
// Created by Jack on 11/18/23.
//
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// ManufacturerKeyboardUITestCase.swift
// BikeIndexUITests
// UITests
//
// Created by Jack on 4/14/24.
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// BikeIndexAppPreviewTest.swift
// BikeIndexTests
// UnitTests
//
// Created by Jack on 12/27/24.
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// BikeIndexOrgApiV3Tests.swift
// BikeIndexTests
// UnitTests
//
// Created by Jack on 11/22/23.
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// BikeModelTests.swift
// BikeIndexTests
// UnitTests
//
// Created by Jack on 11/18/23.
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// BikeRegistration.swift
// BikeIndexTests
// UnitTests
//
// Created by Jack on 12/28/23.
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// ClientRefreshTests.swift
// BikeIndexTests
// UnitTests
//
// Created by Jack on 2/17/24.
//
Expand Down
Loading

0 comments on commit 926215b

Please sign in to comment.