forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable Monolithic build (facebookincubator#9948)
Summary: This PR adds an option that combines all targets into a single `velox` target and build a single unified `libvelox.a`. This is entirely optional and defaults to off. This will make it easier for downstream users to use Velox by just linking to `velox::velox` in their own cmake instead of having to look through our cmake which targets they need. (Once we have a config etc.). I have yet to test the install functionality (it's strictly a bonus, the monolithic build is the goal for now). Pull Request resolved: facebookincubator#9948 Reviewed By: kgpai Differential Revision: D59974408 Pulled By: kevinwilfong fbshipit-source-id: 67459767d247a1264e1c5465c248586ac047ef4f
- Loading branch information
1 parent
db784f6
commit 9f64e42
Showing
94 changed files
with
781 additions
and
356 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Currently this config mostly mirrors the default with the addition of custom functions | ||
| format: | ||
| line_width: 80 | ||
| tab_size: 2 | ||
| use_tabchars: false | ||
| max_pargs_hwrap: 4 | ||
| max_subgroups_hwrap: 2 | ||
| min_prefix_chars: 4 | ||
| max_prefix_chars: 6 | ||
| separate_ctrl_name_with_space: false | ||
| separate_fn_name_with_space: false | ||
| dangle_parens: false | ||
| command_case: "canonical" | ||
| keyword_case: "unchanged" | ||
| always_wrap: | ||
| - set_target_properties | ||
| - target_sources | ||
| - target_link_libraries | ||
|
|
||
| parse: | ||
| # We define these for our custom | ||
| # functions so they get formatted correctly | ||
| additional_commands: | ||
| velox_add_library: | ||
| pargs: | ||
| nargs: 1+ | ||
| flags: | ||
| - OBJECT | ||
| - STATIC | ||
| - SHARED | ||
| - INTERFACE | ||
| kwargs: {} | ||
|
|
||
| velox_base_add_library: | ||
| pargs: | ||
| nargs: 1+ | ||
| flags: | ||
| - OBJECT | ||
| - STATIC | ||
| - SHARED | ||
| - INTERFACE | ||
| kwargs: {} | ||
|
|
||
| velox_compile_definitions: | ||
| pargs: 1 | ||
| kwargs: | ||
| PRIVATE: '*' | ||
| PUBLIC: '*' | ||
| INTERFACE: '*' | ||
|
|
||
| velox_include_directories: | ||
| pargs: '1+' | ||
| flags: | ||
| - SYSTEM | ||
| - BEFORE | ||
| - AFTER | ||
| kwargs: | ||
| PRIVATE: '*' | ||
| PUBLIC: '*' | ||
| INTERFACE: '*' | ||
|
|
||
| velox_link_libraries: | ||
| pargs: '1+' | ||
| kwargs: | ||
| PRIVATE: '*' | ||
| PUBLIC: '*' | ||
| INTERFACE: '*' | ||
|
|
||
| markup: | ||
| first_comment_is_literal: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| include_guard(GLOBAL) | ||
|
|
||
| # TODO use file sets | ||
| function(velox_install_library_headers) | ||
| # Find any headers and install them relative to the source tree in include. | ||
| file(GLOB _hdrs "*.h") | ||
| if(NOT "${_hdrs}" STREQUAL "") | ||
| cmake_path( | ||
| RELATIVE_PATH | ||
| CMAKE_CURRENT_SOURCE_DIR | ||
| BASE_DIRECTORY | ||
| "${CMAKE_SOURCE_DIR}" | ||
| OUTPUT_VARIABLE | ||
| _hdr_dir) | ||
| install(FILES ${_hdrs} DESTINATION include/${_hdr_dir}) | ||
| endif() | ||
| endfunction() | ||
|
|
||
| # Base add velox library call to add a library and install it. | ||
| function(velox_base_add_library TARGET) | ||
| add_library(${TARGET} ${ARGN}) | ||
| install(TARGETS ${TARGET} DESTINATION lib/velox) | ||
| velox_install_library_headers() | ||
| endfunction() | ||
|
|
||
| # This is extremely hackish but presents an easy path to installation. | ||
| function(velox_add_library TARGET) | ||
| set(options OBJECT STATIC SHARED INTERFACE) | ||
| set(oneValueArgs) | ||
| set(multiValueArgs) | ||
| cmake_parse_arguments( | ||
| VELOX | ||
| "${options}" | ||
| "${oneValueArgs}" | ||
| "${multiValueArgs}" | ||
| ${ARGN}) | ||
|
|
||
| # Remove library type specifiers from ARGN | ||
| set(library_type) | ||
| if(VELOX_OBJECT) | ||
| set(library_type OBJECT) | ||
| elseif(VELOX_STATIC) | ||
| set(library_type STATIC) | ||
| elseif(VELOX_SHARED) | ||
| set(library_type SHARED) | ||
| elseif(VELOX_INTERFACE) | ||
| set(library_type INTERFACE) | ||
| endif() | ||
|
|
||
| list(REMOVE_ITEM ARGN OBJECT) | ||
| list(REMOVE_ITEM ARGN STATIC) | ||
| list(REMOVE_ITEM ARGN SHARED) | ||
| list(REMOVE_ITEM ARGN INTERFACE) | ||
| # Propagate to the underlying add_library and then install the target. | ||
| if(VELOX_MONO_LIBRARY) | ||
| if(TARGET velox) | ||
| # Target already exists, append sources to it. | ||
| target_sources(velox PRIVATE ${ARGN}) | ||
| else() | ||
| # Create the target if this is the first invocation. | ||
| add_library(velox ${ARGN}) | ||
| set_target_properties(velox PROPERTIES LIBRARY_OUTPUT_DIRECTORY | ||
| ${CMAKE_BINARY_DIR}/lib) | ||
| set_target_properties(velox PROPERTIES ARCHIVE_OUTPUT_DIRECTORY | ||
| ${CMAKE_BINARY_DIR}/lib) | ||
| install(TARGETS velox DESTINATION lib/velox) | ||
| endif() | ||
| # create alias for compatability | ||
| if(NOT TARGET ${TARGET}) | ||
| add_library(${TARGET} ALIAS velox) | ||
| endif() | ||
| else() | ||
| # Create a library for each invocation. | ||
| velox_base_add_library(${TARGET} ${library_type} ${ARGN}) | ||
| endif() | ||
| velox_install_library_headers() | ||
| endfunction() | ||
|
|
||
| function(velox_link_libraries TARGET) | ||
| # TODO(assignUser): Handle scope keywords (they currently are empty calls ala | ||
| # target_link_libraries(target PRIVATE)) | ||
| if(VELOX_MONO_LIBRARY) | ||
| message(DEBUG "${TARGET}: ${ARGN}") | ||
| foreach(_lib ${ARGN}) | ||
| if("${_lib}" MATCHES "^velox_*") | ||
| message(DEBUG "\t\tDROP: ${_lib}") | ||
| else() | ||
| message(DEBUG "\t\tADDING: ${_lib}") | ||
| target_link_libraries(velox ${_lib}) | ||
| endif() | ||
| endforeach() | ||
| else() | ||
| target_link_libraries(${TARGET} ${ARGN}) | ||
| endif() | ||
| endfunction() | ||
|
|
||
| function(velox_include_directories TARGET) | ||
| if(VELOX_MONO_LIBRARY) | ||
| target_include_directories(velox ${ARGN}) | ||
| else() | ||
| target_include_directories(${TARGET} ${ARGN}) | ||
| endif() | ||
| endfunction() | ||
|
|
||
| function(velox_compile_definitions TARGET) | ||
| if(VELOX_MONO_LIBRARY) | ||
| target_compile_definitions(velox ${ARGN}) | ||
| else() | ||
| target_compile_definitions(${TARGET} ${ARGN}) | ||
| endif() | ||
| endfunction() | ||
|
|
||
| function(velox_sources TARGET) | ||
| if(VELOX_MONO_LIBRARY) | ||
| target_sources(velox ${ARGN}) | ||
| else() | ||
| target_sources(${TARGET} ${ARGN}) | ||
| endif() | ||
| endfunction() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.