forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure inputs are alive before re-using the results of a common sub-e…
…xpression (facebookincubator#10837) Summary: Pull Request resolved: facebookincubator#10837 We recently encountered a bug (facebookincubator#10742) that caused incorrect results when the inputs to a shared expression were replaced with a temporary vector whose lifetime was limited to a single invocation of the expression. This resulted in a new temporary input being passed to the common sub-expression, where this vector had the same memory address but differently mapped rows, and ended up re-using results from a previous invocation. To address this issue, we have made a change to ensure that before re-using the results, we verify that the inputs have not expired. Reviewed By: bikramSingh91 Differential Revision: D61739703 fbshipit-source-id: 52d4bfc9dd34a62ff3472dcfeb9d2c9f5d84ff4c
- Loading branch information
1 parent
47e8958
commit d16b195
Showing
2 changed files
with
46 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters