Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Test with unreleased Bilby #5

Merged
merged 2 commits into from
Apr 12, 2024
Merged

BLD: Test with unreleased Bilby #5

merged 2 commits into from
Apr 12, 2024

Conversation

ColmTalbot
Copy link
Contributor

I updated the test job to run from bilby master so that we can use the unreleased changes.

We may want to run tests both with master and the latest release.

I updated the test job to run from bilby master so that we can use the unreleased changes.

We may want to run tests both with master and the latest release.
@ColmTalbot ColmTalbot requested a review from mj-will April 12, 2024 13:11
@ColmTalbot ColmTalbot changed the title Test with unreleased Bilby BLD: Test with unreleased Bilby Apr 12, 2024
Copy link
Collaborator

@mj-will mj-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ColmTalbot, I think this makes sense until we have a release.

Is there a reason for not testing on Python 3.9? I think the current master still supports it

@ColmTalbot
Copy link
Contributor Author

I had issues with arviz for the numpyro interface, I'll test and if it passes we can include it.

@ColmTalbot
Copy link
Contributor Author

The tests seemed to work so hopefully we're good to merge.

@mj-will
Copy link
Collaborator

mj-will commented Apr 12, 2024

Ah, I see. I think we should try to keep the template as general as possible. People can then remove versions in the individual plugins if need be. What do you think?

Copy link
Collaborator

@mj-will mj-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that change, this looks good to me.

@mj-will mj-will merged commit ade2f65 into main Apr 12, 2024
4 checks passed
@mj-will mj-will deleted the test-from-bilby-master branch April 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants