Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch the page fullscreen from home screen #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Nov 8, 2020

This allows to use "Add to Home screen" button in Chrome to create a shortcut in the launcher that opens Hauk map link like a real app, and not in the browser. Quite useful together with "Preferred link ID", it almost gives the impression of having two activities of Hauk app in my launcher, one (true Hauk app) manages the links and shares, the other one (thanks to this PR) is like an in-app map.

Haven't tested iOS meta tag, I just took it because it was also mentioned in the docs, so I thought why not.

https://developers.google.com/web/fundamentals/native-hardware/fullscreen/#launching_a_page_fullscreen_from_home_screen

@bilde2910
Copy link
Owner

This is an interesting idea. I've had some problematic experiences with PWA in a previous project (caching-related), but this doesn't seem like it implements full PWA with a manifest file, rather just signals to the browser that the online page is app-like. Maybe this could be implemented for custom links only, so that the user isn't prompted to add a temporary link to their home screen. I could also make that setting configurable server-side. I will have to play around with this a bit and get back to your request.

@bilde2910 bilde2910 added the enhancement New feature or request label Nov 12, 2020
@maximbaz
Copy link
Contributor Author

Awesome! Just a note that this change doesn't prompt user about anything new, the only difference is that if they themselves save the link and later open the link, it will open as if in a separate app.

@noerw
Copy link

noerw commented Jun 20, 2022

Hello, what's blocking this from getting merged? I tested the change; it's not intrusive, browsers just offer the option to save a homescreen bookmark

warren-bank added a commit to warren-bank/render-web-services that referenced this pull request Feb 16, 2023
bilde2910/Hauk#157

Enable the ability to launch the webpage fullscreen
from home screen on iOS and Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants