forked from ManageIQ/manageiq-content
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor finish_retirement method for Service Retirement.
This PR is based on the issue below. ManageIQ/manageiq#12038 @miq-bot add_label refactoring @miq-bot assign @tinaafitz Added test for retirement_state equal 'retired' Changed to use a service method
- Loading branch information
1 parent
e1690ea
commit 2b526ef
Showing
2 changed files
with
67 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...geIQ/Service/Retirement/StateMachines/Methods.class/__methods__/finish_retirement_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
require_domain_file | ||
|
||
describe ManageIQ::Automate::Service::Retirement::StateMachines::Methods::FinishRetirement do | ||
let(:admin) { FactoryBot.create(:user_admin) } | ||
let(:request) { FactoryBot.create(:service_retire_request, :requester => admin) } | ||
let(:service) { FactoryBot.create(:service, 'retirement_state' => 'retired') } | ||
let(:task) { FactoryBot.create(:service_retire_task, :destination => service, :miq_request => request) } | ||
let(:svc_task) { MiqAeMethodService::MiqAeServiceServiceRetireTask.find(task.id) } | ||
let(:svc_service) { MiqAeMethodService::MiqAeServiceService.find(service.id) } | ||
let(:root_object) do | ||
Spec::Support::MiqAeMockObject.new('service' => svc_service, | ||
'service_retire_task' => svc_task, | ||
'service_action' => 'Retirement') | ||
end | ||
let(:ae_service) { Spec::Support::MiqAeMockService.new(root_object) } | ||
|
||
it "without service" do | ||
ae_service.root['service'] = nil | ||
expect(ae_service).not_to receive(:create_notification) | ||
expect { described_class.new(ae_service).main }.not_to raise_error | ||
end | ||
|
||
it "retires vm" do | ||
expect(svc_service).to receive(:finish_retirement) | ||
expect(ae_service).to receive(:create_notification).with(:type => :service_retired, :subject => svc_service) | ||
described_class.new(ae_service).main | ||
expect(service.retirement_state).to eq("retired") | ||
end | ||
end |