fix: reliably connecting after 1 retry #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proper setup and cleanup of necessary event listeners so to not have to do this every time we run the connect function.
Also ensure that we're creating new components for each individual camera as to not accidentally re-use old RTCPeerConnections or WebSockets.
This seems to make it so that on the second retry attempt we have about 95% successful connection rate. This leads me to believe that we're still not doing something entirely correctly which is what is causing the inconsistency.
This also still only works over a local network connection, which will have to be addressed at some point.