Fix not diplaying video when audio is present #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyjacoby
previously approved these changes
Sep 12, 2023
billyjacoby
approved these changes
Sep 12, 2023
| @@ -35,8 +35,8 @@ export const WebRTCView = ({cameraName}: WebRTCViewProps) => { | |||
| const [isConnected, setIsConnected] = React.useState<boolean>(false); | |||
| const [retryAttempts, setRetryAttempts] = React.useState(0); | |||
| const [shouldRetry, setShouldRetry] = React.useState(false); | |||
| const [remoteStream, setRemoteStream] = React.useState<MediaStream | null>( | |||
| null, | |||
| const [remoteStream, setRemoteStream] = React.useState<MediaStream>( | |||
There was a problem hiding this comment.
If you don't need to actually use the setRemoteStream function you can just prefix it with an underscore (_setRemoteStream) to prevent that linting error.
But the way this is working now looks like it should be fine. Will test in a bit, having some weird device issues at the moment lol
There was a problem hiding this comment.
Oh good to know! No worries, hopefully all works okay.
|
Completed in 19d1e27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where video stream was not loaded when audio was present, as the video stream was overwritten.
Also fixes an issue whereby the audio stream was not cancelled correctly when changing view of cameras.