Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

salar / Fix: Do not raise socket connection errors #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/LiveApi.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,14 @@ export default class LiveApi {
const urlPlusParams = `${this.apiUrl}?l=${this.language}&app_id=${this.appId}${optionalParam}`;

Object.keys(this.unresolvedPromises).forEach(reqId => {
const disconnectedError = new Error('Websocket disconnected before response received.');
disconnectedError.name = 'DisconnectError';
this.unresolvedPromises[reqId].reject(disconnectedError);
/*
* Swallow connection errors, we can't do anything about them.
* Instead of raising, just log them to the console as a warning.
*/
// const disconnectedError = new Error('Websocket disconnected before response received.');
// disconnectedError.name = 'DisconnectError';
// this.unresolvedPromises[reqId].reject(disconnectedError);
console.warn(`DisconnectError: Websocket disconnected before response received for req ID: ${reqId}.`);
delete this.unresolvedPromises[reqId];
});

Expand Down