Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

chore: updated vars on prod workflow #311

Merged
merged 2 commits into from
Apr 5, 2024
Merged

chore: updated vars on prod workflow #311

merged 2 commits into from
Apr 5, 2024
+3 −3

Conversation

sandeep-deriv
Copy link
Contributor

Change

  • Replaced inputs with the vars in the prod release workflow

review-deriv
review-deriv reviewed Apr 3, 2024
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-api-docs ✅ Ready (Inspect) Visit Preview Apr 4, 2024 5:29am

@coveralls
Copy link

coveralls commented Apr 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8549725396

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.178%
Totals Coverage Status
Change from base Build 8536450160: 0.0%
Covered Lines: 1700
Relevant Lines: 1710
💛 - Coveralls

niloofar-deriv
niloofar-deriv reviewed Apr 4, 2024
View reviewed changes
.github/workflows/release_production.yml Outdated
@@ -57,11 +57,13 @@ jobs:
uses: technote-space/workflow-conclusion-action@45ce8e0eb155657ab8ccf346ade734257fd196a5
- name: Create Slack Message
id: create_slack_message
env:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need this env 🤔

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check

@sandeep-deriv sandeep-deriv merged commit 4c46c87 into binary-com:master Apr 5, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@review-deriv review-deriv review-deriv left review comments

@niloofar-deriv niloofar-deriv niloofar-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandeep-deriv @coveralls @niloofar-deriv @review-deriv