Fix Ruby 1.8.7 Compatibility and Gem Dependencies #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2012 11:16
Check the ruby version and conditionally add a runtime dependency on the right debugging library. Fixes errors installing gem on pre-1.9 versions of Ruby.
We only need these gem dependencies to run the tests, not to load the gem.
ghost
pushed a commit
that referenced
this pull request
Jan 6, 2012
Fix Ruby 1.8.7 Compatibility and Gem Dependencies
ghost
merged commit 
|
Are you sure this won't be overwritten when you'll regenerate the .gemspec (since you're using Jeweler)? |
|
I think you might be right, I don't have a lot of experience with Jeweler. The right answer may be to put all of the gems from the bundle in the :development group so that Jeweler will do the right thing. |
|
I think so, but I personally think Jeweler should be dropped completely and that the .gemspec should be written by hand! :) |
|
I agree with rymai, I'll do that. |
|
Thanks guys, sorry to address this at a level below the root cause. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ben,
It looks like settingslogic 2.0.7 is broken for Ruby 1.8.7 based on Issue #28 and my own experience. This seems to be caused by a new gem dependency on ruby-debug19.
I fixed the gemspec to require the right version of ruby-debug based on 1.8.7 vs. 1.9 support.
Additionally, I don't think these should be runtime gem dependencies, but development depencies - so I switched them over.
This fixes 1.8.7 compatibility for me.
-Winfield