Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go mod call on circleci #1392

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

binhonglee
Copy link
Owner

Not sure what happened here but go mod keeps causing panic consistently since a few days ago. Don't have a good fix for now and its checked on GitHub Action for now anyway so temporarily removing it. (For longer term, we need to migrate the whole CircleCI config since its complaining about legacy stuff in the CI page.)

Copy link
Owner Author

binhonglee commented Jul 24, 2022

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #1392 (aeaa712) into main (008f3d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1392   +/-   ##
=======================================
  Coverage   51.26%   51.26%           
=======================================
  Files          44       44           
  Lines        2915     2915           
  Branches       11       11           
=======================================
  Hits         1494     1494           
  Misses       1421     1421           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daced5...aeaa712. Read the comment docs.

@binhonglee binhonglee marked this pull request as ready for review July 24, 2022 18:30
Copy link
Owner Author

binhonglee commented Jul 25, 2022

Graphite Merge Job

Current status: ⚠️ Downstack blocker

A downstack pull request blocked this pull request from being merged.

This comment was auto-generated by Graphite.

Job Reference: CMJ76Nld0kihdwXeses7

@binhonglee binhonglee force-pushed the 07-24-Fix_PWA_notice_on_light_mode branch from 2d27e90 to 729e23d Compare July 25, 2022 03:22
@binhonglee binhonglee force-pushed the 07-24-Remove_go_mod_call_on_circleci branch from 1b4515b to aeaa712 Compare July 25, 2022 03:22
Copy link
Owner Author

binhonglee commented Jul 25, 2022

Graphite Merge Job

Current status: ⛔ Merge stopped

This pull request was previously queued to merge as part of a stack. It could not be merged because optional checks are failing. To continue, please 1) fix the tests and start a new merge or 2) manually merge past the failing tests.

This comment was auto-generated by Graphite.

Job Reference: LOq9Fql0WFYMm3bFv4tx

Base automatically changed from 07-24-Fix_PWA_notice_on_light_mode to main July 25, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant