Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update build.gradle #21

wants to merge 1 commit into from

Conversation

tudor-pop
Copy link

@tudor-pop tudor-pop commented Nov 18, 2016

with the added code it also generates *-sources.jar and *-docs.jar . I am new with Bintray but I had the surprise of package rejection because of missing sources & docs. That code is from http://stackoverflow.com/questions/11474729/how-to-build-sources-jar-with-gradle and it was given to me by someone from support. To be able to approve the package I had to add the missing jars.

with the added code it also generates *-sources.jar and *-docs.jar . I am new with Bintray but I had the surprise of package rejection because of missing sources & docs. That code is from http://stackoverflow.com/questions/11474729/how-to-build-sources-jar-with-gradle and it was given to be by someone from support, telling me to add the missing jars.
@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 18, 2016

Thank you for this @PopTudor, can you please sign JFrog's CLA so that we can merge this?

@tudor-pop
Copy link
Author

Sorry but I'm good.

@LouisCAD
Copy link

@eyalbe4 Why do you require our address for a PR on example open source code? Why don't you just make it Apache 2.0, and only require us to say our name, email and accept?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 15, 2017

@LouisCAD,
We'll soon add an Apache 2.0 license file this repo.
Contributions through pull requests however do require signing the CLA form.

@LouisCAD
Copy link

@eyalbe4 But can the address field be removed from the CLA please? I think @PopTudor would accept it if it was just a form with name, email, accept checkbox and submit button

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 15, 2017

Let me check that internally @LouisCAD.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 16, 2017

@LouisCAD,
I checked this internally. The address field in the CLA is only used for additional identification of user (it could be the company address or any other address). The format of the form cannot be changed at the moment.
We wouldn't want this however to block anyone from submitting pull requests, so in case you would like submit a PR, and the address field blocks you from doing that, please send me an e-mail ([email protected]) and we'll figure out together how to resolve this for your particular case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants