fixed plot_factors_violin, removing deprecated "s","size" parameters #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
just noticed that the
mofa.plot_factors_violin
has a bug (might be relying on an older seaborn version) and plotting fails with a recent seaborn version (seaborn==0.13.2
):It traces back to
Turns out
sns.violinplot
doesn't accepts
orsize
as an agument (any more?).Removing those two lines (429 and 442) fixes the issue. Dotsize is still adjustable if desired: