Fix undefined names #679
Merged
Fix undefined names #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reece
requested changes
Sep 10, 2023
src/hgvs/dataproviders/uta.py
Outdated
| @@ -624,6 +624,11 @@ def _set_search_path(self, cur): | |||
| cur.execute("set search_path = {self.url.schema},public;".format(self=self)) | |||
|
|
|||
|
|
|||
| class UTA_sqlite(UTABase): | |||
There was a problem hiding this comment.
UTA_sqlite was removed long ago. I think the origin of this concern is uta.py:107, with a case for a sqlite scheme. We should remove that case rather than add an empty class.
Fixes linter error F821.
ecalifornica
force-pushed
the
fix-linter-error-F821
branch
from
ee52656 to
d0943b8
Compare
Fixes linter error F821.
ecalifornica
commented
Sep 11, 2023
There was a problem hiding this comment.
Added these changes since last reviewed, had neglected to run ruff on the tests/ path.
reece
approved these changes
Sep 11, 2023
davmlaw
reviewed
Sep 13, 2023
| from hgvs.exceptions import (HGVSDataNotAvailableError, | ||
| HGVSInvalidVariantError, | ||
| HGVSUnsupportedOperationError) | ||
| from hgvs.parser import Parser |
There was a problem hiding this comment.
This introduced a circular dependency from Parser <-> normalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linter error F821 raised by
ruff. The linefrom hgvs.dataproviders.ncbi import connectis only a guess on my part.Unblocks #673