Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#712): This fixes the broken make develop install #713

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix(#712): This fixes the broken make develop install #713

merged 2 commits into from
Dec 12, 2023

Conversation

andreasprlic
Copy link
Member

This PR fixes the broken make develop, by making sure that the optional dev dependencies are indicated as optional in pyproject.toml.

@andreasprlic andreasprlic requested a review from reece as a code owner December 11, 2023 22:29
@andreasprlic
Copy link
Member Author

... as we can see from the broken CI, apparently make test is also broken ATM

@andreasprlic andreasprlic mentioned this pull request Dec 11, 2023
Open
reece
reece approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@reece reece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. The enforcement of this change has created lots of headaches in many packages that I use. :-(

@reece reece merged commit 2781a4b into main Dec 12, 2023
11 checks passed
@reece reece deleted the 712-fix-dev-install branch December 12, 2023 20:52
This was referenced Dec 12, 2023
Closed
Closed
@jsstevenson jsstevenson mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reece reece reece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasprlic @reece