Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add vcr_config for cassette management and re-run cassettes #755

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

korikuzma
Copy link
Contributor

@korikuzma korikuzma commented Jan 3, 2025

  • set record_mode to fix failing tests
    • ci uses 'none'
    • default uses 'new_episodes' (can overide via VCR_RECORD_MODE env var)
  • re-ran cassettes to update with the correct config

* also updates checkout + setup-python action versions in test
* set record_mode to fix failing tests
  * ci uses 'once'
  * default uses 'new_episodes' (can overide via VCR_RECORD_MODE env var)
* re-ran cassettes to update with the correct config
@korikuzma korikuzma self-assigned this Jan 3, 2025
@korikuzma korikuzma requested a review from a team as a code owner January 3, 2025 04:06
@jsstevenson
Copy link
Contributor

shouldn't vcr mode be none in CI?

Co-authored-by: James Stevenson <[email protected]>
@jsstevenson jsstevenson self-requested a review January 3, 2025 18:26
jsstevenson
jsstevenson previously approved these changes Jan 3, 2025
Base automatically changed from update-test-gh-action to main January 3, 2025 20:29
@korikuzma korikuzma dismissed jsstevenson’s stale review January 3, 2025 20:29

The base branch was changed.

@korikuzma korikuzma requested a review from jsstevenson January 3, 2025 20:30
@korikuzma korikuzma merged commit 677b5c7 into main Jan 6, 2025
11 checks passed
@korikuzma korikuzma deleted the ci-tests branch January 6, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants