Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aarch64 create-env image #59

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Add aarch64 create-env image #59

merged 15 commits into from
Oct 18, 2023

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Oct 17, 2023 •
edited
Loading

bioconda/create-env 3.0 (2023-10-17)

Changed

  • Add linux-aarch64 image; bioconda/create-env is now a multiplatform manifest.

  • Change to a simple "major.minor" version scheme and offer mutable "major" tag.

  • Drop defaults channel from included config.

  • Use Miniforge installer to build this image.

  • Rebuilt on the latest base image with Debian 12.2 / BusyBox 1.36.1.

  • Do not install findutils, sed if provided by the base image (as is currently).

martin-g and others added 7 commits October 17, 2023 10:33
@martin-g @mbargull
Add multi-arch build to create-env workflow
655c524 
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
@martin-g @mbargull
Bump create-env image version to 3.0.0
a03eaa1 
To be in sync with the other image versions in this PR

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
@martin-g @mbargull
Update actions/checkout to v4
0ff93c1 
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
@martin-g @mbargull
Use ubuntu-22.04 Docker action image for all workflows
14755a4 
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@mbargull
Update create-env to the major/major.minor scheme
6541891 
Signed-off-by: Marcel Bargull <[email protected]>
@mbargull
Use Miniforge and mamba for building create-env
bfa4766 
Signed-off-by: Marcel Bargull <[email protected]>
@mbargull
Drop defaults channel explicitly
5fd2839
@mbargull
Ignore deleted/expired tags
fb14ffa 
Signed-off-by: Marcel Bargull <[email protected]>
@mbargull
Conditionally install findutils, sed
a8f1636 
Exclude create-env's own strip, find, xargs, sed binaries from strip.
(The files are in use and their replacement gets into a race condition.)

Signed-off-by: Marcel Bargull <[email protected]>
@mbargull mbargull mentioned this pull request Oct 17, 2023
Closed
@mbargull mbargull force-pushed the create-env-3 branch 2 times, most recently from 22d776e to e356b3f Compare October 17, 2023 20:23
@mbargull mbargull force-pushed the create-env-3 branch 2 times, most recently from e489d2e to a2c86b6 Compare October 17, 2023 21:58
martin-g
martin-g approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbargull
Copy link
Member Author

Thanks for taking a look!
There were yet again some annoying issues with manifest vs image handling, Buildah and Podman command differences, and older Buildah/Podman versions with different behavior/missing features on the CI.
This is finally properly testing for all architectures and ready to push.

@mbargull mbargull merged commit e75e4dd into bioconda:main Oct 18, 2023
2 checks passed
@mjsteinbaugh
Copy link
Member

@mbargull @martin-g Are we ready to roll with working on build recipes for aarch64? Happy to help contribute with that

@martin-g martin-g mentioned this pull request Oct 19, 2023
Merged
7 tasks
@mbargull
Copy link
Member Author

Happy to help contribute with that

That's great, thank you!

Are we ready to roll with working on build recipes for aarch64?

I'm not entirely caught up on everything that is still needed, so I can't say for certain.
In bioconda/bioconda-recipes#40550 work is being done on getting the CI for aarch64 setup.
As I gathered, @martin-g and @Yikun have already looked into building recipes locally. If you'd like to have a look at some recipes before bioconda-recipes' CI is set up, it probably makes sense to look into their work.

@martin-g
Copy link
Contributor

martin-g commented Oct 19, 2023 •
edited
Loading

@mjsteinbaugh Please take a look at bioconda/bioconda-recipes#23454 (comment)
This is what we use to build custom recipes at the moment!
Save it as build-recipes.sh and execute it on Linux aarch64 machine as:

cd path/to/bioconda-recipes/
build-recipes.sh ./recipes msa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbargull @mjsteinbaugh @martin-g