Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nextstrain/auspice to 2.38.0 #36997

Merged
merged 7 commits into from
Sep 17, 2022
Merged

Conversation

jameshadfield
Copy link
Contributor

GitHub release notes: https://github.com/nextstrain/auspice/releases/tag/v2.38.0

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@corneliusroemer
Copy link
Member

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot
Copy link
Collaborator

I received an error uploading the build artifacts or merging the PR!

@corneliusroemer
Copy link
Member

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot
Copy link
Collaborator

I received an error uploading the build artifacts or merging the PR!

@corneliusroemer
Copy link
Member

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

No artifacts found on the most recent Azure build. Either the build failed, the artifacts have were removed due to age, or the recipe was blacklisted/skipped.

@corneliusroemer
Copy link
Member

@BiocondaBot please update

@corneliusroemer
Copy link
Member

@BiocondaBot please fetch artifacts

@corneliusroemer
Copy link
Member

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

No artifacts found on the most recent Azure build. Either the build failed, the artifacts have were removed due to age, or the recipe was blacklisted/skipped.

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot
Copy link
Collaborator

I received an error uploading the build artifacts or merging the PR!

@dpryan79
Copy link
Contributor

Looks like it got blacklisted during the last migration. I've removed it so we can debug that here. nextstrain itself also appears to be in there, so we'll want to get that removed quickly too (different PR though).

@corneliusroemer
Copy link
Member

Thanks @dpryan79!

Is there a changelog explaining what happened with the migration?

I noticed there is now osx-64 etc, but would love to have a detailed discussion. Is that available somewhere?

Was it blacklisted because it didn't work after migration to get the migration done?

Would be nice if there were issues for each blacklisted recipe, with the maintainers of that recipe pinged!

@dpryan79
Copy link
Contributor

There are thousands of packages, so no changelog other than with git. The last migration was for python 3.10.

@corneliusroemer
Copy link
Member

corneliusroemer commented Sep 16, 2022 via email

@dpryan79
Copy link
Contributor

Most likely there were other pinning changes that came along with python 3.10, I unfortunately don't have the full list (we share those with conda-forge, which is doing almost daily updates to their pinnings...so I don't think they even bother keeping track).

@corneliusroemer
Copy link
Member

corneliusroemer commented Sep 16, 2022 via email

@dpryan79
Copy link
Contributor

Yeah, I think there's an issue open on bioconda-utils to have the linting step fail in such cases. It'd be much nicer that way.

@dpryan79
Copy link
Contributor

The error on OSX is Error: lib/auspice/node_modules/watchpack-chokidar2/node_modules/fsevents/build/node_gyp_bins/python3 is a symlink to a path that may not exist after the build is completed (/usr/local/miniconda/envs/bioconda/conda-bld/auspice_1663332189556/_build_env/bin/python3). Do you happen to know if node_gyp_bins actually needs a symlink to python? We can put it in the host section then and make this recipe noarch: python.

@dpryan79
Copy link
Contributor

Ah nodejs/node-gyp#2713

@dpryan79
Copy link
Contributor

Looks like we can put in a for f in $PREFIX/lib/auspice/node_modules/watchpack-chokidar2/node_modules/fsevents/build/node_gyp_bins/python3 ; do unlink $f; done in the build script since this isn't needed after installation.

@dpryan79
Copy link
Contributor

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit fd0d633 into bioconda:master Sep 17, 2022
@corneliusroemer
Copy link
Member

corneliusroemer commented Sep 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants