Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seqan3 to version 3.4.0rc1 #45350

Closed

Conversation

notestaff
Copy link
Member

Update seqan3 to version 3.4.0rc1


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jmarshall
Copy link
Member

Bioconda has not previously packaged SeqAn3 release candidates. Is there a particular reason why this rc1 should be packaged by bioconda?

@notestaff
Copy link
Member Author

@jmarshall The current version (3.3.0) is also marked "pre-release": https://github.com/seqan/seqan3/releases . 3.4.0rc1 fixes some specific issues, e.g. seqan/seqan3#3221, so it would be useful to have it available. If I understand conda version numbering correctly, adding an rc1 version will not change the default version installed when no version is specified?

@jmarshall
Copy link
Member

jmarshall commented Jan 23, 2024

SeqAn3 3.3.0 was preceded by 3.3.0-rc.1 and 3.3.0-rc.2. The names strongly suggest, and are supported by the fact that 3.3.0 appears in CHANGELOG.md and the distinctive “SeqAn 3.3.0 Release” message that appears only in the 3.3.0 tag, that 3.3.0 has erroneously been marked as pre-release on the GitHub releases page.

When upstream make a final 3.4.0 release, bioconda will package it. If they have started making release candidates, presumably that final release is fairly imminent. In the meantime, if you truly need e.g. that one-line compilation fix, it would be appropriate to backport it as a patch to the existing bioconda package.

@jmarshall jmarshall closed this Jan 23, 2024
@eseiler
Copy link
Member

eseiler commented Jan 24, 2024

[...] 3.3.0 has erroneously been marked as pre-release on the GitHub releases page.

That is indeed the case

[...] it would be appropriate to backport it as a patch to the existing bioconda package.

I'll add the patch to the seqan3 package

@eseiler eseiler mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants